kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
To: christophe.jaillet@wanadoo.fr
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Benoit Parrot <bparrot@ti.com>,
	Hans Verkuil <hans.verkuil@cisco.com>,
	linux-media <linux-media@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH V2] media: i2c: ov2659: Fix an error message
Date: Sat, 8 May 2021 13:53:41 +0100	[thread overview]
Message-ID: <CA+V-a8sd7GYGWqvDQX4Zc1Z-t+L1oSSmYUpHrVkB0-6mqVhnBA@mail.gmail.com> (raw)
In-Reply-To: <d995e27db003a26e5b5eb53b0f40b55f8015d873.1620245794.git.christophe.jaillet@wanadoo.fr>

Hi Christophe,

Thank you for the patch.

On Wed, May 5, 2021 at 9:17 PM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> 'ret' is known to be 0 here and printing -ENODEV wouldn't be really
> helpful. So remove it from the error message.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> V2: Remove the Fixes tag. It doesn't really fix something, it just removes
>     a useless information.
>     Just remove ret. No need to add something else.
> ---
>  drivers/media/i2c/ov2659.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
Acked-by: Lad Prabhakar <prabhakar.csengg@gmail.com>

Cheers,
Prabhakar

> diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c
> index 42f64175a6df..6bbbb94fdda4 100644
> --- a/drivers/media/i2c/ov2659.c
> +++ b/drivers/media/i2c/ov2659.c
> @@ -1368,8 +1368,7 @@ static int ov2659_detect(struct v4l2_subdev *sd)
>                 id = OV265X_ID(pid, ver);
>                 if (id != OV2659_ID) {
>                         dev_err(&client->dev,
> -                               "Sensor detection failed (%04X, %d)\n",
> -                               id, ret);
> +                               "Sensor detection failed (%04X)\n", id);
>                         ret = -ENODEV;
>                 } else {
>                         dev_info(&client->dev, "Found OV%04X sensor\n", id);
> --
> 2.30.2
>

      reply	other threads:[~2021-05-08 12:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-05 20:17 [PATCH V2] media: i2c: ov2659: Fix an error message Christophe JAILLET
2021-05-08 12:53 ` Lad, Prabhakar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+V-a8sd7GYGWqvDQX4Zc1Z-t+L1oSSmYUpHrVkB0-6mqVhnBA@mail.gmail.com \
    --to=prabhakar.csengg@gmail.com \
    --cc=bparrot@ti.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=hans.verkuil@cisco.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).