From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AEA1C48BCD for ; Wed, 9 Jun 2021 11:16:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 822FC613AE for ; Wed, 9 Jun 2021 11:16:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238489AbhFILSo (ORCPT ); Wed, 9 Jun 2021 07:18:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237306AbhFILSn (ORCPT ); Wed, 9 Jun 2021 07:18:43 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C683FC061574 for ; Wed, 9 Jun 2021 04:16:48 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id e11so31129327ljn.13 for ; Wed, 09 Jun 2021 04:16:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZpbqtJSZ1KNTljx3ae2/3qbE0gFiJQ1VxWyxhfTI9UM=; b=XYOAJfLEOC5rqg67hcQ6BisKWrEyQaq8X+h5WSoYbIbnqCdASAuMEDJj6t3pSfFzN5 W/qxYWTqnzqceXGB0sf7gn0wixts1Lc064c3JpGb9YGETaR3MPCIXUk8uyOCrmm62HeT m83FsOOdANaST8QQBWyq71b5m2IUcJOjLeGchXQzAbF+AsMlvtJodPHaU+i3ZVIEHpzm Nd2XY2nvaE/k9tug+J4gtGlxKf1AR8QKSi+Apxcu9IeMDoy1MtqLCdgtutd7tjHKFv09 fMHlXtNqVeG0DmkQwS51K5UXBGGpi8ln4miLsPvPgrVLTA5HhbCFL3dCPCwbrTHYSVpV IGrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZpbqtJSZ1KNTljx3ae2/3qbE0gFiJQ1VxWyxhfTI9UM=; b=LeegzDZCj7YdulVCgkryL8dfzWJ+uGwsEWqfKzOV6S2JJFkEEL6RVY+SnOWxwZu4QS NUZ6sIZ6mYOqq0V6S89eBQb5bXr9fJjkY4lZChyNmp1FXNIze9hNtUTLSi2GyFKEtQLn VVjsR3dYj1H3EQpgAabjMIIYCf7d5vjssFGTnntqWr+z4+h10x2SdQ3oUq802EDfs7Q0 inWqFUW2ehTqYCF6fbbAWBNIWHjN1IJuU6M26h+c7ESchZm7ajrc8/3bYCW1Uhf0UkR/ tmDTc9a6RN5jLSG3qlUPnRMKAUvL/NDUm7PraxVYCPc1m9D6anhryyaIElQjhv31p50r Uh6Q== X-Gm-Message-State: AOAM530tC7jugj2/b3ZZoWCfFILFrgMNe6oYtqEe2B/soJgC+DRJy+D9 d3bTekjWzhjhXadLYaeWpvkUe9+cFle0MMOnz+QCsA== X-Google-Smtp-Source: ABdhPJy4w82RLAEdUxCAUBrAJHzaPxPtyjGKrQwy2Q6i1VGLBfN9DtD9QTG1P/hgMU4utYiYrmlz0QzfOUnd6ujMkiQ= X-Received: by 2002:a2e:22c3:: with SMTP id i186mr22165531lji.273.1623237407061; Wed, 09 Jun 2021 04:16:47 -0700 (PDT) MIME-Version: 1.0 References: <20210608143853.4153234-1-weiyongjun1@huawei.com> In-Reply-To: <20210608143853.4153234-1-weiyongjun1@huawei.com> From: Linus Walleij Date: Wed, 9 Jun 2021 13:16:36 +0200 Message-ID: Subject: Re: [PATCH -next] gpio: idt3243x: Fix return value check in idt_gpio_probe() To: Wei Yongjun Cc: Thomas Bogendoerfer , Bartosz Golaszewski , "open list:GPIO SUBSYSTEM" , kernel-janitors@vger.kernel.org, Hulk Robot Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On Tue, Jun 8, 2021 at 4:28 PM Wei Yongjun wrote: > In case of error, the function devm_platform_ioremap_resource_byname() > returns ERR_PTR() and never returns NULL. The NULL test in the return > value check should be replaced with IS_ERR(). > > Fixes: 4195926aedca ("gpio: Add support for IDT 79RC3243x GPIO controller") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun Acked-by: Linus Walleij Yours, Linus Walleij