From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF31CC432BE for ; Mon, 30 Aug 2021 16:08:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A855E61004 for ; Mon, 30 Aug 2021 16:08:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237991AbhH3QJ2 (ORCPT ); Mon, 30 Aug 2021 12:09:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237900AbhH3QJ1 (ORCPT ); Mon, 30 Aug 2021 12:09:27 -0400 Received: from mail-oo1-xc36.google.com (mail-oo1-xc36.google.com [IPv6:2607:f8b0:4864:20::c36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E073BC061575; Mon, 30 Aug 2021 09:08:33 -0700 (PDT) Received: by mail-oo1-xc36.google.com with SMTP id b5-20020a4ac285000000b0029038344c3dso4719379ooq.8; Mon, 30 Aug 2021 09:08:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LGlCF90Prh9n2u4Ctzp39bN3k2Aae1fS0uTteqOOBpc=; b=mrVvliaOqJAmn24rQVts3jWqm9+elkBzrK2b9vJvkzvlwz70Yil6U0wo9wTtfPSmoC earDKTMDrNEG8GYBXXs+6p1dbZUnYbABpKt139wDyV+r4m5sqXbT1DNUdcJadF1SVePo YpCq5kQtn31N2J+nwYNzrI/J+EuoALojR2mWs1J2qIBCBH6kTV5D4iWcFKntFZutsTmh OSJtjxLITUP1ag4fIuH+ZwHbzGrCqvsUMVi6zQ2zuw/ob6nxJap6fT9P/xbRP3D0IZ9H 0gOS2P534zFZSTK5045enfzLub1nXpORbBckmHcAXBf3/yptCWFVbBE+uvEubPj50z9E dkIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LGlCF90Prh9n2u4Ctzp39bN3k2Aae1fS0uTteqOOBpc=; b=NWDoCi3reKzioU95d8DKMxv5h0SgbGW/G7YdLWSQhTe5Tr8FG0Wc7gryufbXpdBDqs 8k/hW8ZTkzOMBEyN2jmb+JIlqdjyVmjheXOV4MBxfw+otWwBar7v/S7PscZJh5BYhPGn CM6WUDvZhSal7fPXKVuYofNO/Gn9u9FyQCzTSejqowv5MiUc9NAGPbkbRRisWivk39u8 ylNa5L7D97Ts3cCOryDTC627RlrkGWPIMNsSqhOWRoFqr+RqXoKZFt2HBaoWScyS1jrm WNVUn/pKWIDG1BY73aQo6Fv/n1cJWLBEt7d8S8nCjPMMKU/T5RIMCYlPBmHtEUpdF0tp dYcA== X-Gm-Message-State: AOAM530z/ZC4bioLTcSOh3X/f6tv/xtJymau3rcCjM1QBFNIXpo6GfAT DAj7SE6+HfcpFaa1ez3DJWxQs7DLyKKq+h9JJc1trGco X-Google-Smtp-Source: ABdhPJxEwEYq7i5z/6MNA82j5/B7YYx63K32JCp9xiws2ESkd7l/CkxeG4uSyZ7nJAQweRTkvQl4bNyL34+7e8vS7BE= X-Received: by 2002:a4a:d108:: with SMTP id k8mr10606732oor.90.1630339713364; Mon, 30 Aug 2021 09:08:33 -0700 (PDT) MIME-Version: 1.0 References: <20210829164624.531391-1-colin.king@canonical.com> In-Reply-To: <20210829164624.531391-1-colin.king@canonical.com> From: Alex Deucher Date: Mon, 30 Aug 2021 12:08:22 -0400 Message-ID: Subject: Re: [PATCH][next] drm/amd/display: Fix unused initialization of pointer sink To: Colin King Cc: Harry Wentland , Leo Li , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , xinhui pan , David Airlie , Daniel Vetter , amd-gfx list , Maling list - DRI developers , kernel-janitors@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org Applied. Thanks! Alex On Sun, Aug 29, 2021 at 12:46 PM Colin King wrote: > > From: Colin Ian King > > Pointer sink is being inintialized with a value that is never read, > it is later being re-assigned a new value. Remove the redundant > initialization. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > index e1e57e7465a7..9331c19fe9cb 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > @@ -10917,7 +10917,7 @@ void amdgpu_dm_update_freesync_caps(struct drm_connector *connector, > struct amdgpu_dm_connector *amdgpu_dm_connector = > to_amdgpu_dm_connector(connector); > struct dm_connector_state *dm_con_state = NULL; > - struct dc_sink *sink = amdgpu_dm_connector->dc_sink; > + struct dc_sink *sink; > > struct drm_device *dev = connector->dev; > struct amdgpu_device *adev = drm_to_adev(dev); > -- > 2.32.0 >