From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Date: Thu, 28 Feb 2019 02:43:41 +0000 Subject: Re: [PATCH -next] drm/amdgpu: remove set but not used variables 'vm, bo' Message-Id: List-Id: References: <20190220033150.163019-1-yuehaibing@huawei.com> In-Reply-To: <20190220033150.163019-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: YueHaibing Cc: Oded Gabbay , "Deucher, Alexander" , Christian Koenig , Chunming Zhou , Dave Airlie , Daniel Vetter , kernel-janitors@vger.kernel.org, amd-gfx list , Maling list - DRI developers , LKML Applied. thanks! On Wed, Feb 20, 2019 at 3:05 AM YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c: In function 'update_gpuvm_pte': > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:840:20: warning: > variable 'bo' set but not used [-Wunused-but-set-variable] > > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:838:20: warning: > variable 'vm' set but not used [-Wunused-but-set-variable] > > They're never used since introduction in a46a2cd103a8 ("drm/amdgpu: Add GPUVM > memory management functions for KFD") > > Signed-off-by: YueHaibing > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c > index d7b10d79f1de..63daf758cd03 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c > @@ -837,13 +837,7 @@ static int update_gpuvm_pte(struct amdgpu_device *adev, > struct amdgpu_sync *sync) > { > int ret; > - struct amdgpu_vm *vm; > - struct amdgpu_bo_va *bo_va; > - struct amdgpu_bo *bo; > - > - bo_va = entry->bo_va; > - vm = bo_va->base.vm; > - bo = bo_va->base.bo; > + struct amdgpu_bo_va *bo_va = entry->bo_va; > > /* Update the page tables */ > ret = amdgpu_vm_bo_update(adev, bo_va, false); > > > > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel