From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EFB4C11F64 for ; Thu, 1 Jul 2021 16:20:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0421D61413 for ; Thu, 1 Jul 2021 16:20:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232491AbhGAQWu (ORCPT ); Thu, 1 Jul 2021 12:22:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230372AbhGAQWs (ORCPT ); Thu, 1 Jul 2021 12:22:48 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8460C0613DB for ; Thu, 1 Jul 2021 09:20:16 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id e3so798355ljo.6 for ; Thu, 01 Jul 2021 09:20:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=brRBtSWPzl3A8EO3IIUcfNsjS22D/ywhnA28QnZfB6M=; b=d1+9kxcLWBvJSpk3fPYeulpwABLezPQJEk+Zy5DmBCHiV5k8fys4vw9rA6zQazJKc2 axsZXI/dx/8bY1setfHEYMO0trSZO9E1jscAwqkUc35Jb6iAXsIo7AKCKK+UvXc4yq3e qiMCd+A5iPA4rWbSxd7fv0SiZp5q2XVbT5RkihF/c9RqhFql0Y9/wfOxBCtfxgXbFAMr Mx7KUZrtHN63OOzj6Yug9Kv/mnaN8sHZt8YTIbHepTjFUeytb0b2nHtfQ8RV40xMkSSe 5qtgbQrElgjEnzp0Iq1NHO5GO/OXxxgwKceI1RgUEbvxexDjJYgB8i2ImLpq/VwKKJNu X9Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=brRBtSWPzl3A8EO3IIUcfNsjS22D/ywhnA28QnZfB6M=; b=Q03VSWUA20FUPDK073hWh+ZrH9DlT4rci1T+P9yCKIUehiMf7G4hRfDyOfWTeoVPMY 9cjOtCJWJpFMa7EuCenwKWA4Fta+Mt60I8U4O2dHs9TmsoNhfM58eUHhbJj1pF2XckC0 N6kb2id/YPvY+VK31e1pkfROuz0GmKbsIc+uPzAvFFS4dhBMdnlNBrFuM++37khe82G1 O28qfdut+yWiZrBIQqlwl1QY1UIg/eS3zW26eTOG6TLFCx/gUJsSPNbf5/16M0rm7pZ+ 9ZBudYAZfpZWyZz/sIAQ/03E8J83PddB35lRvqJNksnFCr+OjPrwDowH3nQiQ4C5kcb2 c9jg== X-Gm-Message-State: AOAM5330ZxhvXtlpXvR8rz+JFvMSrTBW0O9gXJj3EquChBFRB4JJveA3 pvQnLGXjNGJePEd4H/B2Ae9gV6AHUNwjkVc/L8LUwA== X-Google-Smtp-Source: ABdhPJzlkFKmKNMzZS30KJjmaWJKGOg+VZfCnW52PNfjtWzIQLq1y7OZwuioLXRe/ssoxTIomnKsV7xS/xJcAu4SAEI= X-Received: by 2002:a2e:b4ce:: with SMTP id r14mr319557ljm.76.1625156414497; Thu, 01 Jul 2021 09:20:14 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jeroen de Borst Date: Thu, 1 Jul 2021 09:20:03 -0700 Message-ID: Subject: Re: [PATCH 0/3] gve: Fixes and clean-up To: Christophe JAILLET Cc: csully@google.com, sagis@google.com, jonolson@google.com, davem@davemloft.net, kuba@kernel.org, awogbemila@google.com, willemb@google.com, yangchun@google.com, bcf@google.com, kuozhao@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On Wed, Jun 30, 2021 at 10:58 PM Christophe JAILLET wrote: > > This serie is part of the effort to axe the wrappers in > include/linux/pci-dma-compat.h > > While looking at it, I spotted: > - a resource leak in an error handling path (patch 1) > - an error code that could be propagated. (patch 2) > This patch could be ignored. It's only goal is to be more consistent > with other drivers. > > These 2 paches are not related to the 'pci-dma-compat.h' stuff, which can > be found in patch 3. > > Christophe JAILLET (3): > gve: Fix an error handling path in 'gve_probe()' > gve: Propagate error codes to caller > gve: Simplify code and axe the use of a deprecated API > > Thanks for these patches. Can split this into 2 patch series; one for net (with the first 2 patches) and one for net-next (with the cleanup one)? Also the label in the first patch should probably read 'abort_with_gve_init' instead of 'abort_with_vge_init'. Jeroen