From: Masahiro Yamada <masahiroy@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
kernel@esmil.dk, Douglas Anderson <dianders@chromium.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] mmc: uniphier-sd: Fix an error handling path in uniphier_sd_probe()
Date: Mon, 22 Feb 2021 20:45:11 +0900 [thread overview]
Message-ID: <CAK7LNATar8hf7B=HeaWO4D8DhmABXjNZ16H_+KQr=gEx+9Bgrg@mail.gmail.com> (raw)
In-Reply-To: <20210220142935.918554-1-christophe.jaillet@wanadoo.fr>
On Sat, Feb 20, 2021 at 11:31 PM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> A 'uniphier_sd_clk_enable()' call should be balanced by a corresponding
> 'uniphier_sd_clk_disable()' call.
> This is done in the remove function, but not in the error handling path of
> the probe.
>
> Add the missing call.
>
> Fixes: 3fd784f745dd ("mmc: uniphier-sd: add UniPhier SD/eMMC controller driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
I no longer have access to this hardware, but
by browsing the code, this seems correct.
Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>
> drivers/mmc/host/uniphier-sd.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/uniphier-sd.c b/drivers/mmc/host/uniphier-sd.c
> index 2413b6750cec..6f0f05466917 100644
> --- a/drivers/mmc/host/uniphier-sd.c
> +++ b/drivers/mmc/host/uniphier-sd.c
> @@ -635,7 +635,7 @@ static int uniphier_sd_probe(struct platform_device *pdev)
>
> ret = tmio_mmc_host_probe(host);
> if (ret)
> - goto free_host;
> + goto disable_clk;
>
> ret = devm_request_irq(dev, irq, tmio_mmc_irq, IRQF_SHARED,
> dev_name(dev), host);
> @@ -646,6 +646,8 @@ static int uniphier_sd_probe(struct platform_device *pdev)
>
> remove_host:
> tmio_mmc_host_remove(host);
> +disable_clk:
> + uniphier_sd_clk_disable(host);
> free_host:
> tmio_mmc_host_free(host);
>
> --
> 2.27.0
>
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2021-02-22 11:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-20 14:29 [PATCH 1/2] mmc: uniphier-sd: Fix an error handling path in uniphier_sd_probe() Christophe JAILLET
2021-02-22 11:45 ` Masahiro Yamada [this message]
2021-03-02 10:38 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNATar8hf7B=HeaWO4D8DhmABXjNZ16H_+KQr=gEx+9Bgrg@mail.gmail.com' \
--to=masahiroy@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dianders@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@esmil.dk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).