From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bo YU Date: Mon, 22 Jun 2020 00:50:08 +0000 Subject: Re: [PATCH] arch/x86: Check return value from a notify_die() call Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Markus Elfring Cc: kernel-janitors@vger.kernel.org, open list , Alexandre Chartre , Andy Lutomirski , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Ingo Molnar , Jann Horn , Kees Cook , Peter Zijlstra , Thomas Gleixner On Sun, Jun 21, 2020 at 10:40 PM Markus Elfring wrote: > > I propose to improve the previous patch subject. > > > > This is detected by Coverity scan: #CID: 1464472(CHECKED_RETURN) > > > > FIXES: c94082656dac7(x86: Use enum instead of literals for trap values) > > Is the following tag specification more appropriate? > > Fixes: c94082656dac7 ("x86: Use enum instead of literals for trap values") Your description looks like more appropriate, thank you. But I want to receive suggestions from other reviewers also. So I will send V2 patch as your point once got confirmed. Sorry. > > Regards, > Markus