From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jinpu Wang Date: Wed, 09 Dec 2020 08:05:38 +0000 Subject: Re: [PATCH] block/rnbd-clt: Fix error code in rnbd_clt_add_dev_symlink() Message-Id: List-Id: References: <20201209080323.GE2767@kadam> In-Reply-To: <20201209080323.GE2767@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Danil Kipnis , Md Haris Iqbal , Jens Axboe , Lutz Pogrell , linux-block , kernel-janitors@vger.kernel.org On Wed, Dec 9, 2020 at 9:03 AM Dan Carpenter wrote: > > On Wed, Dec 09, 2020 at 08:36:31AM +0100, Jinpu Wang wrote: > > Hi Dan, > > > > > > > > On Wed, Dec 9, 2020 at 7:52 AM Dan Carpenter wrote: > > > > > > The "ret" variable should be set to -ENOMEM but it returns uninitialized > > > stack data. > > > > > > Fixes: 64e8a6ece1a5 ("block/rnbd-clt: Dynamically alloc buffer for pathname & blk_symlink_name") > > > Signed-off-by: Dan Carpenter > > > > Thanks for the patch. But there is already a fix from Colin merged in > > block tree: > > https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-5.11/drivers&ids3c15bd3a944b8eeaacdddf061759b6a83dd3f4 > > > > There is still other problem through with commit 64e8a6ece1a5 > > ("block/rnbd-clt: Dynamically alloc buffer for pathname & > > blk_symlink_name") > > > > I will send the fix today together with other changes. > > Ah... Haha... Sorry about that. We already discussed this yesterday. > > What happens is that when I write a patch, I normally save it in my > postponed messages until the next day. But then I decided to not fix it > but instead to just report it. Unfortunately, I forgot to delete it and > I also forgot about yesterday's discussion because I have the memory of > a gnat. :P > > regards, > dan carpenter > No problem, thanks! :)