From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Jourdan Date: Thu, 13 Jun 2019 09:20:07 +0000 Subject: Re: [PATCH][next] staging: media: meson: remove redundant initialization of mpeg12 Message-Id: List-Id: References: <20190612144218.26149-1-colin.king@canonical.com> In-Reply-To: <20190612144218.26149-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , kernel-janitors@vger.kernel.org, Linux Kernel Mailing List , linux-media@lists.freedesktop.org, Kevin Hilman , linux-amlogic@lists.infradead.org, Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, Linux Media Mailing List Hi Colin, On Wed, Jun 12, 2019 at 4:42 PM Colin King wrote: > > From: Colin Ian King > > The pointer mpeg12 is being initialized however that value is never > read and mpeg12 is being re-assigned almost immediately afterwards. > Remove the redundant initialization. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > drivers/staging/media/meson/vdec/codec_mpeg12.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/meson/vdec/codec_mpeg12.c b/drivers/staging/media/meson/vdec/codec_mpeg12.c > index 5398fbf7ce20..48869cc3d973 100644 > --- a/drivers/staging/media/meson/vdec/codec_mpeg12.c > +++ b/drivers/staging/media/meson/vdec/codec_mpeg12.c > @@ -63,7 +63,7 @@ static void codec_mpeg12_recycle(struct amvdec_core *core, u32 buf_idx) > static int codec_mpeg12_start(struct amvdec_session *sess) > { > struct amvdec_core *core = sess->core; > - struct codec_mpeg12 *mpeg12 = sess->priv; > + struct codec_mpeg12 *mpeg12; > int ret; > > mpeg12 = kzalloc(sizeof(*mpeg12), GFP_KERNEL); > -- > 2.20.1 > Thank you for the patch. Acked-by: Maxime Jourdan