From: Bartosz Golaszewski <brgl@bgdev.pl>
To: "Enrico Weigelt, metux IT consult" <lkml@metux.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Markus Elfring <Markus.Elfring@web.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Keerthy <j-keerthy@ti.com>,
Linus Walleij <linus.walleij@linaro.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-gpio <linux-gpio@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: Adjust scope for CONFIG_HAS_IOMEM before devm_platform_ioremap_resource()
Date: Tue, 25 Jun 2019 07:10:25 +0000 [thread overview]
Message-ID: <CAMRc=Mfp85diy849r_8UHKS9eao26djrsMF0_iwE--d62mQ5jg@mail.gmail.com> (raw)
In-Reply-To: <1dd52704-0e41-db31-33f4-c9f446a47344@metux.net>
pon., 24 cze 2019 o 20:22 Enrico Weigelt, metux IT consult
<lkml@metux.net> napisał(a):
>
> On 24.06.19 12:46, Bartosz Golaszewski wrote:
>
> >> The patch seems pretty trivial and doesn't change any actual code, so
> >> I don't see hard resons for rejecting it.
> >>
> >
> > In its current form it makes the code even less readable. The #ifdef
> > should actually be one line lower and touch the comment instead of the
> > EXPORT_SYMBOL() related to a different function.
>
> Okay, that missing newline should be fixed (as well as the extra one
> after the #ifdef). Besides that, I don't see any further problems.
>
Are we sure this even changes something? Does kernel documentation get
generated according to current config options? I really think this
patch just pollutes the history for now apparent reason.
Greg, could you give your opinion on this?
Bart
next prev parent reply other threads:[~2019-06-25 7:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190221162627.3476-1-brgl@bgdev.pl>
2019-06-14 16:50 ` [PATCH] drivers: Adjust scope for CONFIG_HAS_IOMEM before devm_platform_ioremap_resource() Markus Elfring
2019-06-24 8:29 ` Bartosz Golaszewski
2019-06-24 10:05 ` Enrico Weigelt, metux IT consult
2019-06-24 10:46 ` Bartosz Golaszewski
2019-06-24 11:00 ` Markus Elfring
2019-06-24 18:22 ` [PATCH] " Enrico Weigelt, metux IT consult
2019-06-25 7:10 ` Bartosz Golaszewski [this message]
2019-06-25 7:30 ` Greg Kroah-Hartman
2019-06-25 7:32 ` Bartosz Golaszewski
2019-06-25 7:51 ` Markus Elfring
2019-06-25 7:42 ` Markus Elfring
2019-06-24 10:51 ` [PATCH] " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=Mfp85diy849r_8UHKS9eao26djrsMF0_iwE--d62mQ5jg@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=Markus.Elfring@web.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=j-keerthy@ti.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@metux.net \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).