From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 160A9C48BE8 for ; Fri, 18 Jun 2021 19:21:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F124461260 for ; Fri, 18 Jun 2021 19:21:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234382AbhFRTXU (ORCPT ); Fri, 18 Jun 2021 15:23:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232203AbhFRTXU (ORCPT ); Fri, 18 Jun 2021 15:23:20 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40596C061574; Fri, 18 Jun 2021 12:21:10 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id q20so18374119lfo.2; Fri, 18 Jun 2021 12:21:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NUD8G36VdsiWC+n5lUqd4hu3Ex5au9XROzjkjPU2dP8=; b=IzJZ3MvKB72AkKG9jjEGQSnFkYIn542CcJXVkiQKpix92CvAx7y/WuuLAv1Xs+C+CX N854TOa+OWVSdHnNZ1CZNHPhCnywcx+Fpg6fZqC48LR00A5b/XYGCkqNPxpb07iiVaHC BfsKu6rMtqeej80nhcG2/Ff4I6EbShg+h+pamaBMxgpo1lo4ixx6Saw7Sk5XC+WFjle1 amvUxVVh5mAWyAG2JMnG5qh5wJ0mFbAnc581SR4C2NLaXKMa153JSTw36/rnKVwYnrzO bFxt/Mr6ojNYUsHXp/4TkxorH+xHW0dgTh32YafQ5TbTXhznj8KfNdzzoWBoKnPuVhV6 pXrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NUD8G36VdsiWC+n5lUqd4hu3Ex5au9XROzjkjPU2dP8=; b=pf90z13LJFhUpBgzZMAb+AeSJbGRtr3fmXlUVj9KxwwIWCppfaGcfrjWM1PTEUr2J9 edHNfk1iA5Dhxy4NAsozc7EyzACT1DYSfCaVtpARo1HkoB7caIZm28reVrszqmVzl3uT qd3QyjSPlB6sLXAGjIiU6DtT7ZOsDrA3AC/OnJGaY5rwLFKIyH9/se+C8ac14Qck7sNx H0zXiCcNkN+F8y8vyj69ET6eFNSTm7W9um+Nmw4aLUg1ucBioUneebtZmYMUbP8aGXgw GEwGa4GKlYOEMJvXhYSH7DVBbE/Tp4mPHC0xKq5PZVtk0vY6fcBhIhhcENxGOpnW7Rrd s1cw== X-Gm-Message-State: AOAM533Sc5IzkDQkvKR9dcCWlO3PAc2XYpDk2L4fWKe2nEQeUXdeVTqj J3QOMzeHU6/r2bOwxIGGPRsMVt9ZUDquA3kaNHA= X-Google-Smtp-Source: ABdhPJyGIKidY1tG/LXuXRUf1mMo5ZxqEZVwQ9e0WaUYsuo2c8MfdNNalTrFIqThoXFLfBcSBo+JcxkC0f9t8j/xwRc= X-Received: by 2002:a05:6512:3e0b:: with SMTP id i11mr4483889lfv.139.1624044068616; Fri, 18 Jun 2021 12:21:08 -0700 (PDT) MIME-Version: 1.0 References: <20210618183524.590186-1-colin.king@canonical.com> In-Reply-To: <20210618183524.590186-1-colin.king@canonical.com> From: Patrik Jakobsson Date: Fri, 18 Jun 2021 21:20:57 +0200 Message-ID: Subject: Re: [PATCH] drm/gma500/oaktrail_lvds: replace continue with break To: Colin King Cc: David Airlie , Daniel Vetter , dri-devel , kernel-janitors@vger.kernel.org, linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On Fri, Jun 18, 2021 at 8:35 PM Colin King wrote: > > From: Colin Ian King > > Currently a loop scans through the connector list checking > for connectors that do not match a specific criteria. The > use of the continue statement is a little unintuitive and > can confuse static analysis checking. Invert the criteria > matching logic and use a break to terminate the loop once > the first suitable connector has been found. > > Thanks to Patrik Jakobsson for explaining the original > intent of the code and suggesting this change. Applied to drm-misc-next Thanks for the patch!