From: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Colin King <colin.king@canonical.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel <dri-devel@lists.freedesktop.org>,
kernel-janitors@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/gma500/oaktrail_lvds: replace continue with break
Date: Sat, 19 Jun 2021 22:43:47 +0200 [thread overview]
Message-ID: <CAMeQTsaN-GYzix6X18bWxKY1L13bTrUUYDmp6tFdvaERZEj=3g@mail.gmail.com> (raw)
In-Reply-To: <20210619134025.GH1861@kadam>
On Sat, Jun 19, 2021 at 3:40 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> On Fri, Jun 18, 2021 at 07:35:24PM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Currently a loop scans through the connector list checking
> > for connectors that do not match a specific criteria. The
> > use of the continue statement is a little unintuitive and
> > can confuse static analysis checking. Invert the criteria
> > matching logic and use a break to terminate the loop once
> > the first suitable connector has been found.
> >
> > Thanks to Patrik Jakobsson for explaining the original
> > intent of the code and suggesting this change.
> >
> > Addresses-Coverity: ("Continue has no effect")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > drivers/gpu/drm/gma500/oaktrail_lvds.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/gma500/oaktrail_lvds.c b/drivers/gpu/drm/gma500/oaktrail_lvds.c
> > index 432bdcc57ac9..8541dcf237eb 100644
> > --- a/drivers/gpu/drm/gma500/oaktrail_lvds.c
> > +++ b/drivers/gpu/drm/gma500/oaktrail_lvds.c
> > @@ -113,8 +113,8 @@ static void oaktrail_lvds_mode_set(struct drm_encoder *encoder,
> >
> > /* Find the connector we're trying to set up */
> > list_for_each_entry(connector, &mode_config->connector_list, head) {
> > - if (!connector->encoder || connector->encoder->crtc != crtc)
> > - continue;
> > + if (connector->encoder && connector->encoder->crtc == crtc)
> > + break;
> > }
> >
> > if (!connector) {
>
> This test is wrong/impossible. It should be:
>
> if (list_entry_is_head(connector, &mode_config->connector_list,
> head)) {
Right, we should be back at the head if no match was found. Actually,
when looking closer, we should use drm_for_each_connector_iter() when
walking the connector list together with proper locking.
-Patrik
>
> regards,
> dan carpenter
>
>
prev parent reply other threads:[~2021-06-19 20:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 18:35 [PATCH] drm/gma500/oaktrail_lvds: replace continue with break Colin King
2021-06-18 19:20 ` Patrik Jakobsson
2021-06-19 13:40 ` Dan Carpenter
2021-06-19 20:43 ` Patrik Jakobsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMeQTsaN-GYzix6X18bWxKY1L13bTrUUYDmp6tFdvaERZEj=3g@mail.gmail.com' \
--to=patrik.r.jakobsson@gmail.com \
--cc=airlied@linux.ie \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).