From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C62EC49EA2 for ; Fri, 18 Jun 2021 11:21:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C4FE6128C for ; Fri, 18 Jun 2021 11:21:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233990AbhFRLXe (ORCPT ); Fri, 18 Jun 2021 07:23:34 -0400 Received: from mail-ua1-f47.google.com ([209.85.222.47]:37723 "EHLO mail-ua1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231240AbhFRLXd (ORCPT ); Fri, 18 Jun 2021 07:23:33 -0400 Received: by mail-ua1-f47.google.com with SMTP id f34so3256565uae.4; Fri, 18 Jun 2021 04:21:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LUEdaM1hppiNrgci9zgX87f5flI84RrFcNouNxBCARM=; b=VMjj+D641hTnyVNwzkJetQyb3NdFPfEQ/2PcQM3Ez3Q7IzRzkxcCXB5mYEazQ69LG8 fCbhxayPBi45sPBuyFx9uVnAmzXLBPzq0r3N9JSPyjrJLOb7EeNbv2Qfk2JCmBJEuub1 l1Cj9MwlgKYZnNRsfKLJyQdn9gWt0O0ZzpkeqEdyYVN3oP3A5EflHnz4qFG7nfraQzMb hYK01DZs4uZL1MOhq7zFWgjQkgwkYJuGnIxApj8VdloIR33m+dd3GyP69ihMSkbrxRJT gz3s/m+Nu7ntTQePI5YEBkzRJMbCVajIjsVmBGxX0DPZpw1O8qTQRfAsvkFNE6JWrlvq 46Vw== X-Gm-Message-State: AOAM530uvXX2yD/Mc44WtnUJFSPIM5W5OAITyet9d0+eTMAmOI8ocapd sZ2h33vZVyEW06gFmMHIj7CKpe5F8m22UMOeLQ8= X-Google-Smtp-Source: ABdhPJyooSRBNffX2OYV1jgVsZM9h+Rg5u4fSdcU7u4MbNErD9e3yzpFvVUx42I4K4FOiQUMrw6MShg+1ceE1Jt0nyc= X-Received: by 2002:ab0:70b3:: with SMTP id q19mr11421814ual.2.1624015284122; Fri, 18 Jun 2021 04:21:24 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Geert Uytterhoeven Date: Fri, 18 Jun 2021 13:21:13 +0200 Message-ID: Subject: Re: [PATCH 2/2] clk: renesas: Avoid mixing error pointers and NULL To: Dan Carpenter Cc: Lad Prabhakar , Michael Turquette , Stephen Boyd , Linux-Renesas , linux-clk , Linux Kernel Mailing List , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org Hi Dan, On Thu, Jun 17, 2021 at 4:15 PM Dan Carpenter wrote: > These functions accidentally return both error pointers and NULL when > there is an error. It doesn't cause a problem but it is confusing and > seems unintentional. > > Signed-off-by: Dan Carpenter Reviewed-by: Geert Uytterhoeven i.e. will queue in renesas-clk-for-v5.15. > --- a/drivers/clk/renesas/renesas-rzg2l-cpg.c > +++ b/drivers/clk/renesas/renesas-rzg2l-cpg.c > @@ -124,7 +124,7 @@ rzg2l_cpg_div_clk_register(const struct cpg_core_clk *core, > core->flag, &priv->rmw_lock); > > if (IS_ERR(clk_hw)) > - return NULL; > + return ERR_CAST(clk_hw); > > return clk_hw->clk; > } > @@ -174,17 +174,14 @@ rzg2l_cpg_pll_clk_register(const struct cpg_core_clk *core, > struct clk_init_data init; > const char *parent_name; > struct pll_clk *pll_clk; > - struct clk *clk; > > parent = clks[core->parent & 0xffff]; > if (IS_ERR(parent)) > return ERR_CAST(parent); > > pll_clk = devm_kzalloc(dev, sizeof(*pll_clk), GFP_KERNEL); > - if (!pll_clk) { > - clk = ERR_PTR(-ENOMEM); > - return NULL; > - } > + if (!pll_clk) > + return ERR_PTR(-ENOMEM); This part I already have, by virtue of https://lore.kernel.org/r/1623896524-102058-1-git-send-email-yang.lee@linux.alibaba.com Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds