* [PATCH] ksmbd: Remove redundant 'flush_workqueue()' calls
@ 2021-10-10 13:21 Christophe JAILLET
2021-10-10 14:31 ` Namjae Jeon
2021-10-11 12:19 ` Hyunchul Lee
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2021-10-10 13:21 UTC (permalink / raw)
To: linkinjeon, senozhatsky, sfrench, hyc.lee
Cc: linux-cifs, linux-kernel, kernel-janitors, Christophe JAILLET
'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.
Remove the redundant 'flush_workqueue()' calls.
This was generated with coccinelle:
@@
expression E;
@@
- flush_workqueue(E);
destroy_workqueue(E);
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
fs/ksmbd/ksmbd_work.c | 1 -
fs/ksmbd/transport_rdma.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/fs/ksmbd/ksmbd_work.c b/fs/ksmbd/ksmbd_work.c
index fd58eb4809f6..14b9caebf7a4 100644
--- a/fs/ksmbd/ksmbd_work.c
+++ b/fs/ksmbd/ksmbd_work.c
@@ -69,7 +69,6 @@ int ksmbd_workqueue_init(void)
void ksmbd_workqueue_destroy(void)
{
- flush_workqueue(ksmbd_wq);
destroy_workqueue(ksmbd_wq);
ksmbd_wq = NULL;
}
diff --git a/fs/ksmbd/transport_rdma.c b/fs/ksmbd/transport_rdma.c
index 3a7fa23ba850..0fa7b9c17af3 100644
--- a/fs/ksmbd/transport_rdma.c
+++ b/fs/ksmbd/transport_rdma.c
@@ -2026,7 +2026,6 @@ int ksmbd_rdma_destroy(void)
smb_direct_listener.cm_id = NULL;
if (smb_direct_wq) {
- flush_workqueue(smb_direct_wq);
destroy_workqueue(smb_direct_wq);
smb_direct_wq = NULL;
}
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ksmbd: Remove redundant 'flush_workqueue()' calls
2021-10-10 13:21 [PATCH] ksmbd: Remove redundant 'flush_workqueue()' calls Christophe JAILLET
@ 2021-10-10 14:31 ` Namjae Jeon
2021-10-11 12:19 ` Hyunchul Lee
1 sibling, 0 replies; 3+ messages in thread
From: Namjae Jeon @ 2021-10-10 14:31 UTC (permalink / raw)
To: Christophe JAILLET
Cc: senozhatsky, sfrench, hyc.lee, linux-cifs, linux-kernel, kernel-janitors
2021-10-10 22:21 GMT+09:00, Christophe JAILLET <christophe.jaillet@wanadoo.fr>:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> This was generated with coccinelle:
>
> @@
> expression E;
> @@
> - flush_workqueue(E);
> destroy_workqueue(E);
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ksmbd: Remove redundant 'flush_workqueue()' calls
2021-10-10 13:21 [PATCH] ksmbd: Remove redundant 'flush_workqueue()' calls Christophe JAILLET
2021-10-10 14:31 ` Namjae Jeon
@ 2021-10-11 12:19 ` Hyunchul Lee
1 sibling, 0 replies; 3+ messages in thread
From: Hyunchul Lee @ 2021-10-11 12:19 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Namjae Jeon, Sergey Senozhatsky, Steve French, linux-cifs, LKML,
kernel-janitors
Acked-by: Hyunchul Lee <hyc.lee@gmail.com>
2021년 10월 10일 (일) 오후 10:29, Christophe JAILLET
<christophe.jaillet@wanadoo.fr>님이 작성:
>
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> This was generated with coccinelle:
>
> @@
> expression E;
> @@
> - flush_workqueue(E);
> destroy_workqueue(E);
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> fs/ksmbd/ksmbd_work.c | 1 -
> fs/ksmbd/transport_rdma.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/fs/ksmbd/ksmbd_work.c b/fs/ksmbd/ksmbd_work.c
> index fd58eb4809f6..14b9caebf7a4 100644
> --- a/fs/ksmbd/ksmbd_work.c
> +++ b/fs/ksmbd/ksmbd_work.c
> @@ -69,7 +69,6 @@ int ksmbd_workqueue_init(void)
>
> void ksmbd_workqueue_destroy(void)
> {
> - flush_workqueue(ksmbd_wq);
> destroy_workqueue(ksmbd_wq);
> ksmbd_wq = NULL;
> }
> diff --git a/fs/ksmbd/transport_rdma.c b/fs/ksmbd/transport_rdma.c
> index 3a7fa23ba850..0fa7b9c17af3 100644
> --- a/fs/ksmbd/transport_rdma.c
> +++ b/fs/ksmbd/transport_rdma.c
> @@ -2026,7 +2026,6 @@ int ksmbd_rdma_destroy(void)
> smb_direct_listener.cm_id = NULL;
>
> if (smb_direct_wq) {
> - flush_workqueue(smb_direct_wq);
> destroy_workqueue(smb_direct_wq);
> smb_direct_wq = NULL;
> }
> --
> 2.30.2
>
--
Thanks,
Hyunchul
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-11 12:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-10 13:21 [PATCH] ksmbd: Remove redundant 'flush_workqueue()' calls Christophe JAILLET
2021-10-10 14:31 ` Namjae Jeon
2021-10-11 12:19 ` Hyunchul Lee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).