From: Denis Kirjanov <kda@linux-powerpc.org>
To: Joe Perches <joe@perches.com>
Cc: Colin King <colin.king@canonical.com>,
Raju Rangoju <rajur@chelsio.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cxgb4: clip_tbl: Fix spelling mistake "wont" -> "won't"
Date: Thu, 26 Aug 2021 18:19:22 +0300 [thread overview]
Message-ID: <CAOJe8K1zCRZH-0-+ekDQ5T3mX2cGv1X-gBt1eg4co5HNPP+2vQ@mail.gmail.com> (raw)
In-Reply-To: <6d8179f45f7139ecc8172c2d2c4988b943393c1e.camel@perches.com>
On 8/26/21, Joe Perches <joe@perches.com> wrote:
> On Thu, 2021-08-26 at 13:01 +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> There are spelling mistakes in dev_err and dev_info messages. Fix them.
> []
>> diff --git a/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c
>> b/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c
> []
>> @@ -120,7 +120,7 @@ int cxgb4_clip_get(const struct net_device *dev, const
>> u32 *lip, u8 v6)
>> write_unlock_bh(&ctbl->lock);
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>> dev_err(adap->pdev_dev,
>> "CLIP FW cmd failed with error %d, "
>> - "Connections using %pI6c wont be "
>> + "Connections using %pI6c won't be "
>> "offloaded",
>> ret, ce->addr6.sin6_addr.s6_addr);
>> return ret;
>> @@ -133,7 +133,7 @@ int cxgb4_clip_get(const struct net_device *dev, const
>> u32 *lip, u8 v6)
>> } else {
>> write_unlock_bh(&ctbl->lock);
>> dev_info(adap->pdev_dev, "CLIP table overflow, "
>> - "Connections using %pI6c wont be offloaded",
>> + "Connections using %pI6c won't be offloaded",
>> (void *)lip);
>
> This is an unnecessary cast.
> And these could coalesce the format fragments and add newlines too.
and fix the leftover in the comment:
./t4_hw.c:7185: * set wont be sent when we are flashing FW.
>
>
>
prev parent reply other threads:[~2021-08-26 15:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 12:01 [PATCH] cxgb4: clip_tbl: Fix spelling mistake "wont" -> "won't" Colin King
2021-08-26 14:50 ` Joe Perches
2021-08-26 15:19 ` Denis Kirjanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOJe8K1zCRZH-0-+ekDQ5T3mX2cGv1X-gBt1eg4co5HNPP+2vQ@mail.gmail.com \
--to=kda@linux-powerpc.org \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rajur@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).