* [patch] cpufreq: scpi-cpufreq: signedness bug in scpi_get_dvfs_info()
@ 2015-10-22 19:52 Dan Carpenter
2015-10-23 1:59 ` Viresh Kumar
2015-10-23 10:16 ` Sudeep Holla
0 siblings, 2 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-10-22 19:52 UTC (permalink / raw)
To: linux-arm-kernel
The "domain" variable needs to be signed for the error handling to work.
Fixes: 8def31034d03 ('cpufreq: arm_big_little: add SCPI interface driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c
index 2c3b16f..de5e89b 100644
--- a/drivers/cpufreq/scpi-cpufreq.c
+++ b/drivers/cpufreq/scpi-cpufreq.c
@@ -31,7 +31,7 @@ static struct scpi_ops *scpi_ops;
static struct scpi_dvfs_info *scpi_get_dvfs_info(struct device *cpu_dev)
{
- u8 domain = topology_physical_package_id(cpu_dev->id);
+ int domain = topology_physical_package_id(cpu_dev->id);
if (domain < 0)
return ERR_PTR(-EINVAL);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] cpufreq: scpi-cpufreq: signedness bug in scpi_get_dvfs_info()
2015-10-22 19:52 [patch] cpufreq: scpi-cpufreq: signedness bug in scpi_get_dvfs_info() Dan Carpenter
@ 2015-10-23 1:59 ` Viresh Kumar
2015-10-23 10:16 ` Sudeep Holla
1 sibling, 0 replies; 4+ messages in thread
From: Viresh Kumar @ 2015-10-23 1:59 UTC (permalink / raw)
To: linux-arm-kernel
On 22-10-15, 22:52, Dan Carpenter wrote:
> The "domain" variable needs to be signed for the error handling to work.
>
> Fixes: 8def31034d03 ('cpufreq: arm_big_little: add SCPI interface driver')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c
> index 2c3b16f..de5e89b 100644
> --- a/drivers/cpufreq/scpi-cpufreq.c
> +++ b/drivers/cpufreq/scpi-cpufreq.c
> @@ -31,7 +31,7 @@ static struct scpi_ops *scpi_ops;
>
> static struct scpi_dvfs_info *scpi_get_dvfs_info(struct device *cpu_dev)
> {
> - u8 domain = topology_physical_package_id(cpu_dev->id);
> + int domain = topology_physical_package_id(cpu_dev->id);
>
> if (domain < 0)
> return ERR_PTR(-EINVAL);
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] cpufreq: scpi-cpufreq: signedness bug in scpi_get_dvfs_info()
2015-10-22 19:52 [patch] cpufreq: scpi-cpufreq: signedness bug in scpi_get_dvfs_info() Dan Carpenter
2015-10-23 1:59 ` Viresh Kumar
@ 2015-10-23 10:16 ` Sudeep Holla
2015-11-26 14:07 ` Sudeep Holla
1 sibling, 1 reply; 4+ messages in thread
From: Sudeep Holla @ 2015-10-23 10:16 UTC (permalink / raw)
To: linux-arm-kernel
On 22/10/15 20:52, Dan Carpenter wrote:
> The "domain" variable needs to be signed for the error handling to
> work.
>
> Fixes: 8def31034d03 ('cpufreq: arm_big_little: add SCPI interface
> driver') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Thanks for the fix
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] cpufreq: scpi-cpufreq: signedness bug in scpi_get_dvfs_info()
2015-10-23 10:16 ` Sudeep Holla
@ 2015-11-26 14:07 ` Sudeep Holla
0 siblings, 0 replies; 4+ messages in thread
From: Sudeep Holla @ 2015-11-26 14:07 UTC (permalink / raw)
To: linux-arm-kernel
Hi Rafael,
On Fri, Oct 23, 2015 at 11:16 AM, Sudeep Holla <sudeep.holla@arm.com> wrote:
>
>
> On 22/10/15 20:52, Dan Carpenter wrote:
>>
>> The "domain" variable needs to be signed for the error handling to
>> work.
>>
>> Fixes: 8def31034d03 ('cpufreq: arm_big_little: add SCPI interface
>> driver') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>
> Thanks for the fix
> Acked-by: Sudeep Holla <sudeep.holla@arm.com>
>
Can you pick this up for your next -rc fixes ?
Regards,
Sudeep
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-11-26 14:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-22 19:52 [patch] cpufreq: scpi-cpufreq: signedness bug in scpi_get_dvfs_info() Dan Carpenter
2015-10-23 1:59 ` Viresh Kumar
2015-10-23 10:16 ` Sudeep Holla
2015-11-26 14:07 ` Sudeep Holla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).