Re: [PATCH] usb: gadget: function: printer: Fix use-after-free in __lock_acquire()

Re: [PATCH] usb: gadget: function: printer: Fix use-after-free in __lock_acquire()

[Markus Elfring]

> Fix this by increase object reference count.

I find this description incomplete according to the proposed changes.

Would you like to add the tag “Fixes” to the commit message?

Regards,
Markus

Re: [PATCH] usb: gadget: function: printer: Fix use-after-free in __lock_acquire()

[Greg Kroah-Hartman]

On Fri, Jun 05, 2020 at 10:57:55AM +0200, Markus Elfring wrote:
> > Fix this by increase object reference count.
> 
> I find this description incomplete according to the proposed changes.
> 
> Would you like to add the tag “Fixes” to the commit message?

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.  You seem to
have sent a nonsensical or otherwise pointless review comment to a patch
submission on a Linux kernel developer mailing list.

I strongly suggest that you not do this anymore.  Please do not bother
developers who are actively working to produce patches and features with
comments that, in the end, are a waste of time.

Patch submitter, please ignore this suggestion, it is not needed to be
followed at all, as the person/bot/AI that sent it is on almost all
Linux kernel maintainer's blacklists and is ignored by them.  Please
feel free to also do the same.

thanks,

greg k-h's patch email bot

回复: [PATCH] usb: gadget: function: printer: =?gb2312?B?IEZpeCB1c2UtYWZ

[Zhang, Qiang]

SGkgTWFya3VzLg0KSSBkb24ndCBuZWVkIHRvIGFkZCBGaXggdGFnIHRvIHZpZXcgdGhlIGNvZGUu
DQoNCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18NCreivP7IyzogTWFy
a3VzIEVsZnJpbmcgPE1hcmt1cy5FbGZyaW5nQHdlYi5kZT4NCreiy83KsbzkOiAyMDIwxOo21MI1
yNUgMTY6NTcNCsrVvP7IyzogWmhhbmcsIFFpYW5nOyBsaW51eC11c2JAdmdlci5rZXJuZWwub3Jn
DQqzrcvNOiBrZXJuZWwtamFuaXRvcnNAdmdlci5rZXJuZWwub3JnOyBsaW51eC1rZXJuZWxAdmdl
ci5rZXJuZWwub3JnOyBBbGFuIFN0ZXJuOyBGZWxpcGUgQmFsYmk7IEdyZWcgS3JvYWgtSGFydG1h
bjsgS3l1bmd0YWUgS2ltDQrW98ziOiBSZTogW1BBVENIXSB1c2I6IGdhZGdldDogZnVuY3Rpb246
IHByaW50ZXI6IEZpeCB1c2UtYWZ0ZXItZnJlZSBpbiBfX2xvY2tfYWNxdWlyZSgpDQoNCj4gRml4
IHRoaXMgYnkgaW5jcmVhc2Ugb2JqZWN0IHJlZmVyZW5jZSBjb3VudC4NCg0KSSBmaW5kIHRoaXMg
ZGVzY3JpcHRpb24gaW5jb21wbGV0ZSBhY2NvcmRpbmcgdG8gdGhlIHByb3Bvc2VkIGNoYW5nZXMu
DQoNCldvdWxkIHlvdSBsaWtlIHRvIGFkZCB0aGUgdGFnIKGwRml4ZXOhsSB0byB0aGUgY29tbWl0
IG1lc3NhZ2U/DQoNClJlZ2FyZHMsDQpNYXJrdXMNCg=

Re: usb: gadget: function: printer: Fix use-after-free in __lock_acquire()

[Markus Elfring]

> I don't need to add Fix tag to view the code.

I have got understanding difficulties for this kind of feedback.
How much do you care for corresponding patch review concerns?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id¯7b4801030c07637840191c69eb666917e4135d#n183

Regards,
Markus

Re: usb: gadget: function: printer: Fix use-after-free in __lock_acquire()

[Greg Kroah-Hartman]

On Mon, Jun 08, 2020 at 12:55:13PM +0200, Markus Elfring wrote:
> > I don't need to add Fix tag to view the code.
> 
> I have got understanding difficulties for this kind of feedback.
> How much do you care for corresponding patch review concerns?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id¯7b4801030c07637840191c69eb666917e4135d#n183

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless review
comment to a patch submission on a Linux kernel developer mailing list.
I strongly suggest that you not do this anymore.  Please do not bother
developers who are actively working to produce patches and features with
comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not needed
to follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and inability
to adapt to feedback.  Please feel free to also ignore emails from them.

thanks,

greg k-h's patch email bot

Re: [PATCH] usb: gadget: function: printer: The device interface is reset and should return error co

[Markus Elfring]

I suggest to choose a more succinct patch subject.


> After the device is disconnected from the host side, the interface of
> the device is reset. If the userspace operates the device again,
> an error code should be returned.

Please use an imperative wording for the commit message.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=719fdd32921fb7e3208db8832d32ae1c2d68900f#n151


> Signed-off-by: Zqiang <qiang.zhang@windriver.com>

Did you really specify your real name here?

Regards,
Markus

Re: [PATCH] usb: gadget: function: printer: The device interface is reset and should return error co

[Greg Kroah-Hartman]

On Sun, Jun 28, 2020 at 03:43:10PM +0200, Markus Elfring wrote:
> I suggest to choose a more succinct patch subject.
> 
> 
> > After the device is disconnected from the host side, the interface of
> > the device is reset. If the userspace operates the device again,
> > an error code should be returned.
> 
> Please use an imperative wording for the commit message.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?idq9fdd32921fb7e3208db8832d32ae1c2d68900f#n151
> 
> 
> > Signed-off-by: Zqiang <qiang.zhang@windriver.com>
> 
> Did you really specify your real name here?
> 
> Regards,
> Markus

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot