kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Cercueil <paul@crapouillou.net>
To: Wolfram Sang <wsa@kernel.org>
Cc: Colin King <colin.king@canonical.com>,
	linux-i2c@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: jz4780: remove redundant assignment to variable i
Date: Mon, 06 Jul 2020 23:52:29 +0000	[thread overview]
Message-ID: <HNN2DQ.3HHBK0781A0A1@crapouillou.net> (raw)
In-Reply-To: <20200704063217.GG1041@kunai>

Hi,

Le sam. 4 juil. 2020 à 8:32, Wolfram Sang <wsa@kernel.org> a écrit :
> On Wed, Jun 10, 2020 at 01:59:01PM +0100, Colin King wrote:
>>  From: Colin Ian King <colin.king@canonical.com>
>> 
>>  The variable i is being initialized with a value that is
>>  never read and it is being updated later with a new value. The
>>  initialization is redundant and can be removed.
>> 
>>  Addresses-Coverity: ("Unused value")
>>  Signed-off-by: Colin Ian King <colin.king@canonical.com>
> 
> What about 'ret'? Doesn't the same reasoning apply for it?
> 

That's correct.

Colin, could you respin the patch and do the same for the 'ret' 
variable?

Thanks,
-Paul

      reply	other threads:[~2020-07-06 23:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-10 12:59 [PATCH] i2c: jz4780: remove redundant assignment to variable i Colin King
2020-07-04  6:32 ` Wolfram Sang
2020-07-06 23:52   ` Paul Cercueil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=HNN2DQ.3HHBK0781A0A1@crapouillou.net \
    --to=paul@crapouillou.net \
    --cc=colin.king@canonical.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).