kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] igb: Fix an error handling path in 'igb_probe()'
@ 2021-06-12 20:08 Christophe JAILLET
  2021-06-25 22:39 ` [Intel-wired-lan] " Brelinski, TonyX
  0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2021-06-12 20:08 UTC (permalink / raw)
  To: jesse.brandeburg, anthony.l.nguyen, davem, kuba,
	jeffrey.t.kirsher, alexander.h.duyck
  Cc: intel-wired-lan, netdev, linux-kernel, kernel-janitors,
	Christophe JAILLET

If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it
must be undone by a corresponding 'pci_disable_pcie_error_reporting()'
call, as already done in the remove function.

Fixes: 40a914fa72ab ("igb: Add support for pci-e Advanced Error Reporting")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/net/ethernet/intel/igb/igb_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index 5db303d64d14..cf1de2b9ab71 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -3615,6 +3615,7 @@ static int igb_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 err_ioremap:
 	free_netdev(netdev);
 err_alloc_etherdev:
+	pci_disable_pcie_error_reporting(pdev);
 	pci_release_mem_regions(pdev);
 err_pci_reg:
 err_dma:
-- 
2.30.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-25 22:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-12 20:08 [PATCH] igb: Fix an error handling path in 'igb_probe()' Christophe JAILLET
2021-06-25 22:39 ` [Intel-wired-lan] " Brelinski, TonyX

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).