From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFF3AC43460 for ; Wed, 19 May 2021 14:18:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D9AB613B0 for ; Wed, 19 May 2021 14:18:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345928AbhESOT2 (ORCPT ); Wed, 19 May 2021 10:19:28 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:55496 "EHLO mx0b-00069f02.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354080AbhESOSb (ORCPT ); Wed, 19 May 2021 10:18:31 -0400 Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14JEAuqv032331; Wed, 19 May 2021 14:17:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=ttNoL6vgSqzxpKKnbEpf/kAYwaiUjRWRovcI3xZDGdE=; b=0GdMpxmsosE0EL3MAhz7ajiIk6idjGHJUCgE4mKUSGgcUy9blt2nYhGfEBuSBvEMx8/g i9hHiUW6KUxbvn4YfuYE+WB+Gr5Vzy+3lclh3RX/Jwp+q8APzZyyksPYjxM3xSmKMs8d zwuaFddWJQG4cLsjr7+4SXl1Sz+0wgnY7FiWOn4JYZw8HbJFXhpd6rWBCCjm70w8oI3/ jsWib6SNVGJjSce9YALqWa/xzqugGdPP6gyQJJxVDoxMJgkv5Mgj79E7m1Gmh4GP3zpv 4G7R6ONYB4KYLJOCNqHLMS8elG3Zln3sWpKn9Ug+bte1RCc/lBKCR3jUW8lE3/sRBeUd qw== Received: from oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 38kh0h95sv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 19 May 2021 14:17:01 +0000 Received: from aserp3030.oracle.com (aserp3030.oracle.com [127.0.0.1]) by pps.podrdrct (8.16.0.36/8.16.0.36) with SMTP id 14JEBnqs181104; Wed, 19 May 2021 14:17:01 GMT Received: from pps.reinject (localhost [127.0.0.1]) by aserp3030.oracle.com with ESMTP id 38meeg5mx4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 19 May 2021 14:17:01 +0000 Received: from aserp3030.oracle.com (aserp3030.oracle.com [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 14JEGm2q000820; Wed, 19 May 2021 14:17:00 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 38meeg5mwm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 19 May 2021 14:17:00 +0000 Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 14JEGwpG030507; Wed, 19 May 2021 14:16:58 GMT Received: from mwanda (/41.212.42.34) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 19 May 2021 07:16:57 -0700 Date: Wed, 19 May 2021 17:16:50 +0300 From: Dan Carpenter To: Greg Kroah-Hartman , Somya Anand Cc: Alex Dewar , Sean Behan , Kumar Kartikeya Dwivedi , linux-staging@lists.linux.dev, kernel-janitors@vger.kernel.org Subject: [PATCH] staging: emxx_udc: fix loop in _nbu2ss_nuke() Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210518082855.GB32682@kadam> X-Mailer: git-send-email haha only kidding X-Proofpoint-GUID: l8gXSyTnNlChFqyjx9ZduCya7AJHYhzx X-Proofpoint-ORIG-GUID: l8gXSyTnNlChFqyjx9ZduCya7AJHYhzx Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org The _nbu2ss_ep_done() function calls: list_del_init(&req->queue); which means that the loop will never exit. Fixes: ca3d253eb967 ("Staging: emxx_udc: Iterate list using list_for_each_entry") Signed-off-by: Dan Carpenter --- drivers/staging/emxx_udc/emxx_udc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c index 741147a4f0fe..ecc5c9da9027 100644 --- a/drivers/staging/emxx_udc/emxx_udc.c +++ b/drivers/staging/emxx_udc/emxx_udc.c @@ -2064,7 +2064,7 @@ static int _nbu2ss_nuke(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep, int status) { - struct nbu2ss_req *req; + struct nbu2ss_req *req, *n; /* Endpoint Disable */ _nbu2ss_epn_exit(udc, ep); @@ -2076,7 +2076,7 @@ static int _nbu2ss_nuke(struct nbu2ss_udc *udc, return 0; /* called with irqs blocked */ - list_for_each_entry(req, &ep->queue, queue) { + list_for_each_entry_safe(req, n, &ep->queue, queue) { _nbu2ss_ep_done(ep, req, status); } -- 2.30.2