From: Leon Romanovsky <leon@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Saeed Mahameed <saeedm@nvidia.com>
Cc: Paul Blakey <paulb@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] net/mlx5: check for allocation failure in mlx5_ft_pool_init()
Date: Thu, 3 Jun 2021 16:12:38 +0300 [thread overview]
Message-ID: <YLjVRjAyP3UpzgVr@unreal> (raw)
In-Reply-To: <YLjNfHuTQ817oUtX@mwanda>
On Thu, Jun 03, 2021 at 03:39:24PM +0300, Dan Carpenter wrote:
> Add a check for if the kzalloc() fails.
>
> Fixes: 4a98544d1827 ("net/mlx5: Move chains ft pool to be used by all firmware steering")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/fs_ft_pool.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_ft_pool.c b/drivers/net/ethernet/mellanox/mlx5/core/fs_ft_pool.c
> index 526fbb669142..c14590acc772 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/fs_ft_pool.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/fs_ft_pool.c
> @@ -27,6 +27,8 @@ int mlx5_ft_pool_init(struct mlx5_core_dev *dev)
> int i;
>
> ft_pool = kzalloc(sizeof(*ft_pool), GFP_KERNEL);
> + if (!ft_pool)
> + return -ENOMEM;
>
> for (i = ARRAY_SIZE(FT_POOLS) - 1; i >= 0; i--)
> ft_pool->ft_left[i] = FT_SIZE / FT_POOLS[i];
Dan thanks for your patch.
When reviewed your patch, I spotted another error in the patch from the Fixes line.
2955 err = mlx5_ft_pool_init(dev);
2956 if (err)
2957 return err;
2958
2959 steering = kzalloc(sizeof(*steering), GFP_KERNEL);
2960 if (!steering)
2961 goto err;
^^^^^^^^ it will return success, while should return ENOMEM.
Thanks,
Acked-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2021-06-03 13:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 12:39 [PATCH net-next] net/mlx5: check for allocation failure in mlx5_ft_pool_init() Dan Carpenter
2021-06-03 13:12 ` Leon Romanovsky [this message]
2021-06-03 15:46 ` Dan Carpenter
2021-06-03 19:17 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLjVRjAyP3UpzgVr@unreal \
--to=leon@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulb@nvidia.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).