* [PATCH] nvme-tcp-offload: Fix error code in nvme_tcp_ofld_create_ctrl()
@ 2021-06-09 9:28 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2021-06-09 9:28 UTC (permalink / raw)
To: Shai Malin
Cc: Ariel Elior, Keith Busch, Jens Axboe, Christoph Hellwig,
Sagi Grimberg, Igor Russkikh, David S. Miller, Hannes Reinecke,
linux-nvme, linux-kernel, kernel-janitors
Return an error pointer if try_module_get() fails. Currently it returns
NULL.
Fixes: 4b8178ec5794 ("nvme-tcp-offload: Add device scan implementation")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/nvme/host/tcp-offload.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/tcp-offload.c b/drivers/nvme/host/tcp-offload.c
index c76822e5ada7..c07f84a7e697 100644
--- a/drivers/nvme/host/tcp-offload.c
+++ b/drivers/nvme/host/tcp-offload.c
@@ -1215,7 +1215,7 @@ nvme_tcp_ofld_create_ctrl(struct device *ndev, struct nvmf_ctrl_options *opts)
/* Increase driver refcnt */
if (!try_module_get(dev->ops->module)) {
pr_err("try_module_get failed\n");
- dev = NULL;
+ rc = -ENODEV;
goto out_free_ctrl;
}
--
2.30.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-06-09 11:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-09 9:28 [PATCH] nvme-tcp-offload: Fix error code in nvme_tcp_ofld_create_ctrl() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).