* [PATCH] scsi: elx: libefc: signedness bug in efc_d_send_prli_rsp()
@ 2021-06-18 13:42 Dan Carpenter
2021-06-19 15:44 ` James Smart
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2021-06-18 13:42 UTC (permalink / raw)
To: James Smart
Cc: Ram Vegesna, James E.J. Bottomley, Martin K. Petersen,
Daniel Wagner, Hannes Reinecke, linux-scsi, target-devel,
kernel-janitors
The "rc" variable needs to be signed for the error handling to work.
It holds either a negative error code, EFC_SCSI_CALL_COMPLETE (0),
or EFC_SCSI_CALL_ASYNC (1).
Fixes: 202bfdffae27 ("scsi: elx: libefc: FC node ELS and state handling")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/scsi/elx/libefc/efc_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/elx/libefc/efc_device.c b/drivers/scsi/elx/libefc/efc_device.c
index 31a688bce6e9..725ca2a23fb2 100644
--- a/drivers/scsi/elx/libefc/efc_device.c
+++ b/drivers/scsi/elx/libefc/efc_device.c
@@ -15,7 +15,7 @@
void
efc_d_send_prli_rsp(struct efc_node *node, u16 ox_id)
{
- u32 rc = EFC_SCSI_CALL_COMPLETE;
+ int rc = EFC_SCSI_CALL_COMPLETE;
struct efc *efc = node->efc;
node->ls_acc_oxid = ox_id;
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: elx: libefc: signedness bug in efc_d_send_prli_rsp()
2021-06-18 13:42 [PATCH] scsi: elx: libefc: signedness bug in efc_d_send_prli_rsp() Dan Carpenter
@ 2021-06-19 15:44 ` James Smart
0 siblings, 0 replies; 2+ messages in thread
From: James Smart @ 2021-06-19 15:44 UTC (permalink / raw)
To: Dan Carpenter, James Smart
Cc: Ram Vegesna, James E.J. Bottomley, Martin K. Petersen,
Daniel Wagner, Hannes Reinecke, linux-scsi, target-devel,
kernel-janitors
On 6/18/2021 6:42 AM, Dan Carpenter wrote:
> The "rc" variable needs to be signed for the error handling to work.
> It holds either a negative error code, EFC_SCSI_CALL_COMPLETE (0),
> or EFC_SCSI_CALL_ASYNC (1).
>
> Fixes: 202bfdffae27 ("scsi: elx: libefc: FC node ELS and state handling")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/scsi/elx/libefc/efc_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks!
Reviewed-by: James Smart <jsmart2021@gmail.com>
-- james
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-19 15:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-18 13:42 [PATCH] scsi: elx: libefc: signedness bug in efc_d_send_prli_rsp() Dan Carpenter
2021-06-19 15:44 ` James Smart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).