From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CF8FC4338F for ; Sun, 25 Jul 2021 16:38:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5501360F39 for ; Sun, 25 Jul 2021 16:38:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230378AbhGYP5w (ORCPT ); Sun, 25 Jul 2021 11:57:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:36800 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229709AbhGYP5w (ORCPT ); Sun, 25 Jul 2021 11:57:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8E98860295; Sun, 25 Jul 2021 16:38:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627231102; bh=OeOmKuniJGa777vFw6wze0AYSgrohQrzXyVZL8teTa8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D6h4D+Mw/nAUslgxCIJhHKQbscpZSt7O2dj0PljMukqbCEnTLsHxDRhD+nsjCW6rH ZeQAFBH3nofy/zFd341WiQxqsOYQ0YYnH8b5jKhsp1Fzgg3EZu5TBJTm14gFiioD4V IO2tN/XOmCLM9wNOH3bjejTeh8gnGhqWsYvrh+a4= Date: Sun, 25 Jul 2021 18:38:19 +0200 From: Greg Kroah-Hartman To: Christophe JAILLET Cc: Martin Kaiser , linux-staging@lists.linux.dev, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/18] staging: rtl8188eu: remove unused _HAL_INTF_C_ define Message-ID: References: <20210725155902.32433-1-martin@kaiser.cx> <20210725155902.32433-9-martin@kaiser.cx> <2bfef837-e8f6-0a89-b0ac-967de12ed067@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2bfef837-e8f6-0a89-b0ac-967de12ed067@wanadoo.fr> Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On Sun, Jul 25, 2021 at 06:32:10PM +0200, Christophe JAILLET wrote: > Le 25/07/2021 à 17:58, Martin Kaiser a écrit : > > This define can be removed. > > > > Signed-off-by: Martin Kaiser > > --- > > drivers/staging/rtl8188eu/hal/hal_intf.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c b/drivers/staging/rtl8188eu/hal/hal_intf.c > > index f09620c54e69..3e132e00c81c 100644 > > --- a/drivers/staging/rtl8188eu/hal/hal_intf.c > > +++ b/drivers/staging/rtl8188eu/hal/hal_intf.c > > @@ -5,7 +5,6 @@ > > * > > ******************************************************************************/ > > -#define _HAL_INTF_C_ > > #include > > uint rtw_hal_init(struct adapter *adapt) > > > > Hi, > > This one looks like an include guard. > > #ifndef _HAL_INTF_C_ > #define _HAL_INTF_C_ > ... > #endif /* _HAL_INTF_C_ */ > > ? But it really does not do anything, so should be dropped as the patch does. Unless I am reading the code wrong? greg k-h