From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Colin King <colin.king@canonical.com>
Cc: Namjae Jeon <linkinjeon@kernel.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steve French <sfrench@samba.org>,
Hyunchul Lee <hyc.lee@gmail.com>,
linux-cifs@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] ksmbd: add missing assignments to ret on ndr_read_int64 read calls
Date: Tue, 7 Sep 2021 09:08:01 +0900 [thread overview]
Message-ID: <YTatYScZNOYHxruf@google.com> (raw)
In-Reply-To: <20210906134438.14250-1-colin.king@canonical.com>
On (21/09/06 14:44), Colin King wrote:
[..]
> @@ -275,11 +275,11 @@ int ndr_decode_dos_attr(struct ndr *n, struct xattr_dos_attrib *da)
> if (ret)
> return ret;
>
> - ndr_read_int64(n, NULL);
> + ret = ndr_read_int64(n, NULL);
> if (ret)
> return ret;
>
> - ndr_read_int64(n, NULL);
> + ret = ndr_read_int64(n, NULL);
> if (ret)
> return ret;
A pretty nice catch by that static analyzer tool.
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
prev parent reply other threads:[~2021-09-07 0:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 13:44 [PATCH][next] ksmbd: add missing assignments to ret on ndr_read_int64 read calls Colin King
2021-09-06 23:31 ` Namjae Jeon
2021-09-07 0:08 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTatYScZNOYHxruf@google.com \
--to=senozhatsky@chromium.org \
--cc=colin.king@canonical.com \
--cc=hyc.lee@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).