From: Dan Carpenter <dan.carpenter@oracle.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Support Opensource <support.opensource@diasemi.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: da7219: Fix an error handling path in da7219_register_dai_clks()
Date: Fri, 23 Sep 2022 12:42:14 +0300 [thread overview]
Message-ID: <Yy1/dhtp3VCCRkWI@kadam> (raw)
In-Reply-To: <e4acceab57a0d9e477a8d5890a45c5309e553e7c.1663875789.git.christophe.jaillet@wanadoo.fr>
On Thu, Sep 22, 2022 at 09:44:57PM +0200, Christophe JAILLET wrote:
> If clk_hw_register() fails, the corresponding clk should not be
> unregistered.
>
> To handle errors from loops, clean up partial iterations before doing the
> goto. So add a clk_hw_unregister().
> Then use a while (--i >= 0) loop in the unwind section.
>
> Fixes: 78013a1cf297 ("ASoC: da7219: Fix clock handling around codec level probe")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> See https://lore.kernel.org/all/4fdde55198294a07f04933f7cef937fcb654c901.1624425670.git.christophe.jaillet@wanadoo.fr/
> for an incomplete patch sent last year and Dan's comment on it.
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
next prev parent reply other threads:[~2022-09-23 9:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 19:44 [PATCH] ASoC: da7219: Fix an error handling path in da7219_register_dai_clks() Christophe JAILLET
2022-09-23 9:42 ` Dan Carpenter [this message]
2022-09-27 10:34 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yy1/dhtp3VCCRkWI@kadam \
--to=dan.carpenter@oracle.com \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=support.opensource@diasemi.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).