From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Elfring Date: Tue, 23 Jun 2020 12:45:21 +0000 Subject: Re: [v2 1/2] ASoC: fsl_mqs: Don't check clock is NULL before calling clk API Message-Id: List-Id: References: <39ac8f24-3148-2a3d-3f8d-91567b3c4c9e@web.de> <24be48d2-63de-b900-cec7-d21e83a89ca2@web.de> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Shengjiu Wang , alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org Cc: Timur Tabi , Xiubo Li , Shengjiu Wang , kernel-janitors@vger.kernel.org, Takashi Iwai , linux-kernel@vger.kernel.org, Nicolin Chen , Mark Brown , Fabio Estevam >>> if the parameter >>> is NULL, clk_prepare_enable and clk_disable_unprepare will >>> return immediately. >> >> The interpretation of these function implementations seems to be reasonable. >> Would you like to achieve any improvements for the corresponding software documentation? > > Which document do you mean? Example: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/clk.h?id=dd0d718152e4c65b173070d48ea9dfc06894c3e5#n905 https://elixir.bootlin.com/linux/v5.7.2/source/include/linux/clk.h#L905 Regards, Markus