From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Date: Wed, 02 Dec 2020 08:13:53 +0000 Subject: Re: [PATCH] vhost_vdpa: return -EFAULT if copy_to_user() fails Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Dan Carpenter , "Michael S. Tsirkin" Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, kernel-janitors@vger.kernel.org On 2020/12/2 下午2:44, Dan Carpenter wrote: > The copy_to_user() function returns the number of bytes remaining to be > copied but this should return -EFAULT to the user. > > Fixes: 1b48dc03e575 ("vhost: vdpa: report iova range") > Signed-off-by: Dan Carpenter > --- > drivers/vhost/vdpa.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c > index d6a37b66770b..ef688c8c0e0e 100644 > --- a/drivers/vhost/vdpa.c > +++ b/drivers/vhost/vdpa.c > @@ -344,7 +344,9 @@ static long vhost_vdpa_get_iova_range(struct vhost_vdpa *v, u32 __user *argp) > .last = v->range.last, > }; > > - return copy_to_user(argp, &range, sizeof(range)); > + if (copy_to_user(argp, &range, sizeof(range))) > + return -EFAULT; > + return 0; > } > > static long vhost_vdpa_vring_ioctl(struct vhost_vdpa *v, unsigned int cmd, Acked-by: Jason Wang Thanks