* Re: [PATCH v2] media: venus: core: Fix runtime PM imbalance in venus_probe
@ 2020-06-24 15:25 Markus Elfring
0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-06-24 15:25 UTC (permalink / raw)
To: Dinghao Liu, linux-arm-msm, linux-media
Cc: kernel-janitors, linux-kernel, Aditya Pakki, Navid Emamdoost,
Kangjie Lu, Qiushi Wu, Andy Gross, Mauro Carvalho Chehab,
Stanimir Varbanov, Bjorn Andersson
I propose to combine two tags in the previous patch subject.
> pm_runtime_get_sync() increments the runtime PM usage counter even
> when it returns an error code. Thus a pairing decrement is needed on
> the error handling path to keep the counter balanced. For other error
> paths after this call, things are the same.
How do you think about a wording variant like the following?
The PM runtime usage counter is incremented even if a call of
the function “pm_runtime_get_sync” failed. Thus decrement it also
in error cases so that the reference counting is kept consistent.
Add also a call of the function “pm_runtime_get_noresume”
in one if branch for the completion of the desired exception handling.
Would you like to add the tag “Fixes” to the commit message?
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-06-24 15:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-24 15:25 [PATCH v2] media: venus: core: Fix runtime PM imbalance in venus_probe Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).