From: Stefano Stabellini <sstabellini@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: boris.ostrovsky@oracle.com, jgross@suse.com,
sstabellini@kernel.org, xen-devel@lists.xenproject.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] xen/pvcalls-back: Remove redundant 'flush_workqueue()' calls
Date: Thu, 14 Oct 2021 12:42:42 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.2110141242320.9408@sstabellini-ThinkPad-T480s> (raw)
In-Reply-To: <2d6c2e031e4aa2acf2ac4e0bbbc17cfdcc8dbee2.1634236560.git.christophe.jaillet@wanadoo.fr>
On Thu, 14 Oct 2021, Christophe JAILLET wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> This was generated with coccinelle:
>
> @@
> expression E;
> @@
> - flush_workqueue(E);
> destroy_workqueue(E);
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> drivers/xen/pvcalls-back.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
> index b47fd8435061..d6f945fd4147 100644
> --- a/drivers/xen/pvcalls-back.c
> +++ b/drivers/xen/pvcalls-back.c
> @@ -465,7 +465,6 @@ static int pvcalls_back_release_passive(struct xenbus_device *dev,
> write_unlock_bh(&mappass->sock->sk->sk_callback_lock);
> }
> sock_release(mappass->sock);
> - flush_workqueue(mappass->wq);
> destroy_workqueue(mappass->wq);
> kfree(mappass);
>
> --
> 2.30.2
>
next prev parent reply other threads:[~2021-10-14 19:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 18:37 [PATCH] xen/pvcalls-back: Remove redundant 'flush_workqueue()' calls Christophe JAILLET
2021-10-14 19:42 ` Stefano Stabellini [this message]
2021-10-27 13:20 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2110141242320.9408@sstabellini-ThinkPad-T480s \
--to=sstabellini@kernel.org \
--cc=boris.ostrovsky@oracle.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=jgross@suse.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).