Re: [PATCH 03/18] [ARM] pata_icside: use semicolons rather than commas to separate statements

From: Julia Lawall <julia.lawall@inria.fr>
To: Joe Perches <joe@perches.com>
Cc: "Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
	"Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	kernel-janitors@vger.kernel.org, "Jens Axboe" <axboe@kernel.dk>,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/18] [ARM] pata_icside: use semicolons rather than commas to separate statements
Date: Mon, 28 Sep 2020 17:11:16 +0000	[thread overview]
Message-ID: <alpine.DEB.2.22.394.2009281909000.2650@hadrien> (raw)
In-Reply-To: <8cf2fad1659acd756703deb106d55483bd1e1eb9.camel@perches.com>

On Mon, 28 Sep 2020, Joe Perches wrote:

> On Sun, 2020-09-27 at 21:12 +0200, Julia Lawall wrote:
> > Replace commas with semicolons.  What is done is essentially described by
> > the following Coccinelle semantic patch (http://coccinelle.lip6.fr/):
>
> Hi Julia.
>
> How did you decide on this patch subject header line?
>
> It's certainly reasonable, but not what I would expect
> from any automation.

Most of the patches on this file touch other files as well.  There are
four that only touch this file.  One has no subsystem.  One has dma as the
subsystem.  Two have pata_icside, so that was chosen.

I found that taking the most popular overall could give results that were
too general.

julia

>
> A somewhat common method of finding the most commonly used
> "git log" subject line doesn't easily provide a similar heading.
>
> $ git log --no-merges --format='%s' drivers/ata/pata_icside.c
> treewide: Add SPDX license identifier for more missed files
> libata: remove ata_sff_data_xfer_noirq()
> scsi: rename SCSI_MAX_{SG, SG_CHAIN}_SEGMENTS
> Drivers: ata: remove __dev* attributes.
> ata: Convert ata_<foo>_printk(KERN_<LEVEL> to ata_<foo>_<level>
> libata-sff: separate out BMDMA irq handler
> libata-sff: separate out BMDMA EH
> libata-sff: clean up BMDMA initialization
> libata-sff: clean up inheritance in several drivers
> include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
> [libata] convert drivers to use ata.h mode mask defines
> [ARM] dma: Use sensible DMA parameters for Acorn drivers
> [ARM] dma: pata_icside's contiguous sg array is now redundant
> libata-sff: Fix oops reported in kerneloops.org for pnp devices with no ctl
> libata: rename SFF port ops
> libata: rename SFF functions
> libata: make reset related methods proper port operations
> libata: implement and use ops inheritance
> libata: implement and use SHT initializers
> libata: implement and use ata_noop_irq_clear()
> libata: eliminate the home grown dma padding in favour of
> libata: convert to chained sg
> Fix pata_icside build for recent libata API changes
> libata: implement and use ata_port_desc() to report port configuration
> [libata] Remove ->port_disable() hook
> [libata] Remove ->irq_ack() hook, and ata_dummy_irq_on()
> [ARM] pata_icside: fix the FIXMEs
> [libata] PATA drivers: remove ATA_FLAG_SRST
> [ARM] pata_icside: fix build errors
> [ARM] ecard: add ecardm_iomap() / ecardm_iounmap()
> [ARM] ecard: add helper function for setting ecard irq ops
> [ARM] Add support for ICSIDE interface on RiscPC
>
> $ git log --no-merges --format='%s' drivers/ata/pata_icside.c | \
>   cut -f1 -d":" | sort | uniq -c | sort -rn
>      10 libata
>       5 libata-sff
>       2 [ARM] pata_icside
>       2 [ARM] ecard
>       2 [ARM] dma
>       1 treewide
>       1 scsi
>       1 [libata] Remove ->port_disable() hook
>       1 [libata] Remove ->irq_ack() hook, and ata_dummy_irq_on()
>       1 [libata] PATA drivers
>       1 [libata] convert drivers to use ata.h mode mask defines
>       1 include cleanup
>       1 Fix pata_icside build for recent libata API changes
>       1 Drivers
>       1 ata
>       1 [ARM] Add support for ICSIDE interface on RiscPC
>
>
>