From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Kosina Date: Thu, 09 Jul 2015 12:28:53 +0000 Subject: Re: [PATCH v2] HID: Wacom: Delete unnecessary checks before the function call "input_free_device" Message-Id: List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <5479D93E.3040407@users.sourceforge.net> <559E0FCF.8000908@users.sourceforge.net> In-Reply-To: <559E0FCF.8000908@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: linux-input@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall On Thu, 9 Jul 2015, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 9 Jul 2015 08:00:10 +0200 > > The input_free_device() function tests whether its argument is NULL and > then returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring This is really on a "is it worth it?" borderline, but anyway ... applied to for-4.3/upstream. Thanks, -- Jiri Kosina SUSE Labs