* Re: [PATCH] media: davinci: vpif_capture: fix potential double free
@ 2020-07-23 20:15 Markus Elfring
2020-07-24 20:08 ` Evgeny Novikov
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2020-07-23 20:15 UTC (permalink / raw)
To: Evgeny Novikov, ldv-project, linux-media
Cc: linux-kernel, kernel-janitors, Mauro Carvalho Chehab, Prabhakar Lad
> In case of errors vpif_probe_complete() releases memory for vpif_obj.sd
> and unregisters the V4L2 device. But then this is done again by
> vpif_probe() itself. The patch removes the cleaning from
> vpif_probe_complete().
* An imperative wording can be preferred for the change description,
can't it?
* Would you like to add the tag “Fixes” to the commit message?
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] media: davinci: vpif_capture: fix potential double free
2020-07-23 20:15 [PATCH] media: davinci: vpif_capture: fix potential double free Markus Elfring
@ 2020-07-24 20:08 ` Evgeny Novikov
0 siblings, 0 replies; 2+ messages in thread
From: Evgeny Novikov @ 2020-07-24 20:08 UTC (permalink / raw)
To: Markus Elfring, ldv-project, linux-media
Cc: linux-kernel, kernel-janitors, Mauro Carvalho Chehab, Prabhakar Lad
Hi Markus,
It seems that Lad Prabhakar detected a critical issue introduced by the patch instead of a minor bug fixed by it. So, we should take care of this first, but I will address your notes as well.
--
Evgeny Novikov
Linux Verification Center, ISP RAS
http://linuxtesting.org
23.07.2020, 23:15, "Markus Elfring" <markus.elfring@web.de>:
>> In case of errors vpif_probe_complete() releases memory for vpif_obj.sd
>> and unregisters the V4L2 device. But then this is done again by
>> vpif_probe() itself. The patch removes the cleaning from
>> vpif_probe_complete().
>
> * An imperative wording can be preferred for the change description,
> can't it?
>
> * Would you like to add the tag “Fixes” to the commit message?
>
> Regards,
> Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-24 20:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-23 20:15 [PATCH] media: davinci: vpif_capture: fix potential double free Markus Elfring
2020-07-24 20:08 ` Evgeny Novikov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).