From: Suman Anna <s-anna@ti.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
<ohad@wizery.com>, <bjorn.andersson@linaro.org>,
<mathieu.poirier@linaro.org>
Cc: <linux-remoteproc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] remoteproc: k3-r5: Fix an error message
Date: Thu, 6 May 2021 18:51:30 -0500 [thread overview]
Message-ID: <b585d9e1-8b52-aa1e-211d-fa79be6a5d55@ti.com> (raw)
In-Reply-To: <d6e29d903b48957bf59c67229d54b0fc215e31ae.1620333870.git.christophe.jaillet@wanadoo.fr>
On 5/6/21 3:46 PM, Christophe JAILLET wrote:
> 'ret' is known to be 0 here.
> Reorder the code so that the expected error code is printed.
>
> Fixes: 6dedbd1d5443 ("remoteproc: k3-r5: Add a remoteproc driver for R5F subsystem")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Thanks for catching the issue.
Acked-by: Suman Anna <s-anna@ti.com>
regards
Suman
> ---
> drivers/remoteproc/ti_k3_r5_remoteproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/ti_k3_r5_remoteproc.c b/drivers/remoteproc/ti_k3_r5_remoteproc.c
> index 5cf8d030a1f0..4104e4846dbf 100644
> --- a/drivers/remoteproc/ti_k3_r5_remoteproc.c
> +++ b/drivers/remoteproc/ti_k3_r5_remoteproc.c
> @@ -1272,9 +1272,9 @@ static int k3_r5_core_of_init(struct platform_device *pdev)
>
> core->tsp = k3_r5_core_of_get_tsp(dev, core->ti_sci);
> if (IS_ERR(core->tsp)) {
> + ret = PTR_ERR(core->tsp);
> dev_err(dev, "failed to construct ti-sci proc control, ret = %d\n",
> ret);
> - ret = PTR_ERR(core->tsp);
> goto err;
> }
>
>
next prev parent reply other threads:[~2021-05-06 23:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 20:46 [PATCH] remoteproc: k3-r5: Fix an error message Christophe JAILLET
2021-05-06 23:51 ` Suman Anna [this message]
2021-05-07 5:26 ` Dan Carpenter
2021-05-07 5:58 ` Christophe JAILLET
2021-05-07 6:59 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b585d9e1-8b52-aa1e-211d-fa79be6a5d55@ti.com \
--to=s-anna@ti.com \
--cc=bjorn.andersson@linaro.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).