kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mtd: mchp48l640: silence some uninitialized variable warnings
@ 2021-06-18 13:42 Dan Carpenter
  2021-06-19  6:21 ` Heiko Schocher
  2021-07-15 22:50 ` Miquel Raynal
  0 siblings, 2 replies; 6+ messages in thread
From: Dan Carpenter @ 2021-06-18 13:42 UTC (permalink / raw)
  To: Miquel Raynal
  Cc: Richard Weinberger, Vignesh Raghavendra, Heiko Schocher,
	linux-mtd, kernel-janitors

Smatch complains that zero length read/writes will lead to an
uninitalized return value.  I don't know if that's possible, but
it's nicer to return a zero literal anyway so let's do that.

Fixes: 88d125026753 ("mtd: devices: add support for microchip 48l640 EERAM")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
People, when we add a new driver can we make sure the first commit uses
the new prefered subsystem prefix?  For example,

"mtd: mchp48l640: add support for microchip 48l640 EERAM"
      ^^^^^^^^^^
Otherwise it's not clear to me what I should use as a patch prefix.

 drivers/mtd/devices/mchp48l640.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/devices/mchp48l640.c b/drivers/mtd/devices/mchp48l640.c
index efc2003bd13a..ad66b5aaf4e9 100644
--- a/drivers/mtd/devices/mchp48l640.c
+++ b/drivers/mtd/devices/mchp48l640.c
@@ -229,7 +229,7 @@ static int mchp48l640_write(struct mtd_info *mtd, loff_t to, size_t len,
 		woff += ws;
 	}
 
-	return ret;
+	return 0;
 }
 
 static int mchp48l640_read_page(struct mtd_info *mtd, loff_t from, size_t len,
@@ -286,7 +286,7 @@ static int mchp48l640_read(struct mtd_info *mtd, loff_t from, size_t len,
 		woff += ws;
 	}
 
-	return ret;
+	return 0;
 };
 
 static const struct mchp48_caps mchp48l640_caps = {
-- 
2.30.2


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] mtd: mchp48l640: silence some uninitialized variable warnings
  2021-06-18 13:42 [PATCH] mtd: mchp48l640: silence some uninitialized variable warnings Dan Carpenter
@ 2021-06-19  6:21 ` Heiko Schocher
  2021-06-22 15:31   ` Fabio Estevam
  2021-07-15 22:50 ` Miquel Raynal
  1 sibling, 1 reply; 6+ messages in thread
From: Heiko Schocher @ 2021-06-19  6:21 UTC (permalink / raw)
  To: Dan Carpenter, Miquel Raynal
  Cc: Richard Weinberger, Vignesh Raghavendra, linux-mtd, kernel-janitors

Hello Dan,

On 18.06.21 15:42, Dan Carpenter wrote:
> Smatch complains that zero length read/writes will lead to an
> uninitalized return value.  I don't know if that's possible, but
> it's nicer to return a zero literal anyway so let's do that.
> 
> Fixes: 88d125026753 ("mtd: devices: add support for microchip 48l640 EERAM")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> People, when we add a new driver can we make sure the first commit uses
> the new prefered subsystem prefix?  For example,
> 
> "mtd: mchp48l640: add support for microchip 48l640 EERAM"
>       ^^^^^^^^^^
> Otherwise it's not clear to me what I should use as a patch prefix.

Ok, sorry...

Hmm... Colin already sent a fix for this, see:

https://lists.infradead.org/pipermail/linux-mtd/2021-June/087140.html

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs@denx.de

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] mtd: mchp48l640: silence some uninitialized variable warnings
  2021-06-19  6:21 ` Heiko Schocher
@ 2021-06-22 15:31   ` Fabio Estevam
  2021-06-22 15:39     ` Colin Ian King
  0 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2021-06-22 15:31 UTC (permalink / raw)
  To: Heiko Schocher
  Cc: Dan Carpenter, Miquel Raynal, Richard Weinberger,
	Vignesh Raghavendra, linux-mtd, kernel-janitors, Colin King

On Sat, Jun 19, 2021 at 3:23 AM Heiko Schocher <hs@denx.de> wrote:
>
> Hello Dan,
>
> On 18.06.21 15:42, Dan Carpenter wrote:
> > Smatch complains that zero length read/writes will lead to an
> > uninitalized return value.  I don't know if that's possible, but
> > it's nicer to return a zero literal anyway so let's do that.
> >
> > Fixes: 88d125026753 ("mtd: devices: add support for microchip 48l640 EERAM")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > People, when we add a new driver can we make sure the first commit uses
> > the new prefered subsystem prefix?  For example,
> >
> > "mtd: mchp48l640: add support for microchip 48l640 EERAM"
> >       ^^^^^^^^^^
> > Otherwise it's not clear to me what I should use as a patch prefix.
>
> Ok, sorry...
>
> Hmm... Colin already sent a fix for this, see:
>
> https://lists.infradead.org/pipermail/linux-mtd/2021-June/087140.html

Yes, both patches work, but I think Dan's solution is a bit clearer, so:

Reviewed-by: Fabio Estevam <festevam@gmail.com>

Thanks

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] mtd: mchp48l640: silence some uninitialized variable warnings
  2021-06-22 15:31   ` Fabio Estevam
@ 2021-06-22 15:39     ` Colin Ian King
  2021-06-23  3:22       ` Heiko Schocher
  0 siblings, 1 reply; 6+ messages in thread
From: Colin Ian King @ 2021-06-22 15:39 UTC (permalink / raw)
  To: Fabio Estevam, Heiko Schocher
  Cc: Dan Carpenter, Miquel Raynal, Richard Weinberger,
	Vignesh Raghavendra, linux-mtd, kernel-janitors

On 22/06/2021 16:31, Fabio Estevam wrote:
> On Sat, Jun 19, 2021 at 3:23 AM Heiko Schocher <hs@denx.de> wrote:
>>
>> Hello Dan,
>>
>> On 18.06.21 15:42, Dan Carpenter wrote:
>>> Smatch complains that zero length read/writes will lead to an
>>> uninitalized return value.  I don't know if that's possible, but
>>> it's nicer to return a zero literal anyway so let's do that.
>>>
>>> Fixes: 88d125026753 ("mtd: devices: add support for microchip 48l640 EERAM")
>>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>> ---
>>> People, when we add a new driver can we make sure the first commit uses
>>> the new prefered subsystem prefix?  For example,
>>>
>>> "mtd: mchp48l640: add support for microchip 48l640 EERAM"
>>>       ^^^^^^^^^^
>>> Otherwise it's not clear to me what I should use as a patch prefix.
>>
>> Ok, sorry...
>>
>> Hmm... Colin already sent a fix for this, see:
>>
>> https://lists.infradead.org/pipermail/linux-mtd/2021-June/087140.html
> 
> Yes, both patches work, but I think Dan's solution is a bit clearer, so:
> 
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> 
> Thanks
> 
Yep, I'm good with that.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] mtd: mchp48l640: silence some uninitialized variable warnings
  2021-06-22 15:39     ` Colin Ian King
@ 2021-06-23  3:22       ` Heiko Schocher
  0 siblings, 0 replies; 6+ messages in thread
From: Heiko Schocher @ 2021-06-23  3:22 UTC (permalink / raw)
  To: Colin Ian King, Fabio Estevam
  Cc: Dan Carpenter, Miquel Raynal, Richard Weinberger,
	Vignesh Raghavendra, linux-mtd, kernel-janitors

Hello Colin, Dan,

On 22.06.21 17:39, Colin Ian King wrote:
> On 22/06/2021 16:31, Fabio Estevam wrote:
>> On Sat, Jun 19, 2021 at 3:23 AM Heiko Schocher <hs@denx.de> wrote:
>>>
>>> Hello Dan,
>>>
>>> On 18.06.21 15:42, Dan Carpenter wrote:
>>>> Smatch complains that zero length read/writes will lead to an
>>>> uninitalized return value.  I don't know if that's possible, but
>>>> it's nicer to return a zero literal anyway so let's do that.
>>>>
>>>> Fixes: 88d125026753 ("mtd: devices: add support for microchip 48l640 EERAM")
>>>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>>> ---
>>>> People, when we add a new driver can we make sure the first commit uses
>>>> the new prefered subsystem prefix?  For example,
>>>>
>>>> "mtd: mchp48l640: add support for microchip 48l640 EERAM"
>>>>       ^^^^^^^^^^
>>>> Otherwise it's not clear to me what I should use as a patch prefix.
>>>
>>> Ok, sorry...
>>>
>>> Hmm... Colin already sent a fix for this, see:
>>>
>>> https://lists.infradead.org/pipermail/linux-mtd/2021-June/087140.html
>>
>> Yes, both patches work, but I think Dan's solution is a bit clearer, so:
>>
>> Reviewed-by: Fabio Estevam <festevam@gmail.com>
>>
>> Thanks
>>
> Yep, I'm good with that.

+1

Reviewed-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs@denx.de

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] mtd: mchp48l640: silence some uninitialized variable warnings
  2021-06-18 13:42 [PATCH] mtd: mchp48l640: silence some uninitialized variable warnings Dan Carpenter
  2021-06-19  6:21 ` Heiko Schocher
@ 2021-07-15 22:50 ` Miquel Raynal
  1 sibling, 0 replies; 6+ messages in thread
From: Miquel Raynal @ 2021-07-15 22:50 UTC (permalink / raw)
  To: Dan Carpenter, Miquel Raynal
  Cc: Richard Weinberger, Vignesh Raghavendra, Heiko Schocher,
	linux-mtd, kernel-janitors

On Fri, 2021-06-18 at 13:42:07 UTC, Dan Carpenter wrote:
> Smatch complains that zero length read/writes will lead to an
> uninitalized return value.  I don't know if that's possible, but
> it's nicer to return a zero literal anyway so let's do that.
> 
> Fixes: 88d125026753 ("mtd: devices: add support for microchip 48l640 EERAM")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> Reviewed-by: Heiko Schocher <hs@denx.de>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks.

Miquel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-07-15 22:50 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-18 13:42 [PATCH] mtd: mchp48l640: silence some uninitialized variable warnings Dan Carpenter
2021-06-19  6:21 ` Heiko Schocher
2021-06-22 15:31   ` Fabio Estevam
2021-06-22 15:39     ` Colin Ian King
2021-06-23  3:22       ` Heiko Schocher
2021-07-15 22:50 ` Miquel Raynal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).