From: Markus Elfring <Markus.Elfring@web.de>
To: Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
linux-crypto@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Ayush Sawal <ayush.sawal@chelsio.com>,
"David S. Miller" <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
Rohit Maheshwari <rohitm@chelsio.com>,
Vinay Kumar Yadav <vinay.yadav@chelsio.com>
Subject: Re: [PATCH 2/2] Crypto/chcr: Fix some pr_xxx messages
Date: Mon, 13 Jul 2020 20:00:30 +0000 [thread overview]
Message-ID: <bc539dfe-969f-7593-81ef-56b736150e25@web.de> (raw)
In-Reply-To: <20200712211424.276263-1-christophe.jaillet@wanadoo.fr>
…
> +++ b/drivers/crypto/chelsio/chcr_algo.c
> @@ -1224,7 +1224,7 @@ static int chcr_handle_cipher_resp(struct skcipher_request *req,
> wrparam.bytes = bytes;
> skb = create_cipher_wr(&wrparam);
> if (IS_ERR(skb)) {
> - pr_err("chcr : %s : Failed to form WR. No memory\n", __func__);
> + pr_err("%s : Failed to form WR. No memory\n", __func__);
> err = PTR_ERR(skb);
> goto unmap;
> }
I suggest to omit also a space character before the colon in such format strings.
+ pr_err("%s: Failed to form WR. No memory\n", __func__);
Would you like to apply any further fine-tuning around affected error messages?
Regards,
Markus
next prev parent reply other threads:[~2020-07-13 20:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-12 21:14 [PATCH 2/2] Crypto/chcr: Fix some pr_xxx messages Christophe JAILLET
2020-07-13 20:00 ` Markus Elfring [this message]
2020-07-16 11:56 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc539dfe-969f-7593-81ef-56b736150e25@web.de \
--to=markus.elfring@web.de \
--cc=ayush.sawal@chelsio.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rohitm@chelsio.com \
--cc=vinay.yadav@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).