kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] e1000e: Fix an error handling path in 'e1000_probe()'
@ 2021-06-16  5:05 Christophe JAILLET
  2021-06-22  8:31 ` [Intel-wired-lan] " Neftin, Sasha
  2021-06-24 13:37 ` Fuxbrumer, Dvora
  0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2021-06-16  5:05 UTC (permalink / raw)
  To: jesse.brandeburg, anthony.l.nguyen, davem, kuba, jeffrey.t.kirsher
  Cc: intel-wired-lan, netdev, linux-kernel, kernel-janitors,
	Christophe JAILLET

If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it
must be undone by a corresponding 'pci_disable_pcie_error_reporting()'
call, as already done in the remove function.

Fixes: 111b9dc5c981 ("e1000e: add aer support")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/net/ethernet/intel/e1000e/netdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index 5435606149b0..c8aa69fd0405 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -7662,6 +7662,7 @@ static int e1000_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 err_ioremap:
 	free_netdev(netdev);
 err_alloc_etherdev:
+	pci_disable_pcie_error_reporting(pdev);
 	pci_release_mem_regions(pdev);
 err_pci_reg:
 err_dma:
-- 
2.30.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Intel-wired-lan] [PATCH] e1000e: Fix an error handling path in 'e1000_probe()'
  2021-06-16  5:05 [PATCH] e1000e: Fix an error handling path in 'e1000_probe()' Christophe JAILLET
@ 2021-06-22  8:31 ` Neftin, Sasha
  2021-06-24 13:37 ` Fuxbrumer, Dvora
  1 sibling, 0 replies; 3+ messages in thread
From: Neftin, Sasha @ 2021-06-22  8:31 UTC (permalink / raw)
  To: Christophe JAILLET, jesse.brandeburg, anthony.l.nguyen, davem,
	kuba, Edri, Michael
  Cc: netdev, kernel-janitors, intel-wired-lan, linux-kernel, Neftin, Sasha

On 6/16/2021 08:05, Christophe JAILLET wrote:
> If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it
> must be undone by a corresponding 'pci_disable_pcie_error_reporting()'
> call, as already done in the remove function.
> 
> Fixes: 111b9dc5c981 ("e1000e: add aer support")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>   drivers/net/ethernet/intel/e1000e/netdev.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
> index 5435606149b0..c8aa69fd0405 100644
> --- a/drivers/net/ethernet/intel/e1000e/netdev.c
> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c
> @@ -7662,6 +7662,7 @@ static int e1000_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>   err_ioremap:
>   	free_netdev(netdev);
>   err_alloc_etherdev:
> +	pci_disable_pcie_error_reporting(pdev);
>   	pci_release_mem_regions(pdev);
>   err_pci_reg:
>   err_dma:
> 
Acked-by: Sasha Neftin <sasha.neftin@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Intel-wired-lan] [PATCH] e1000e: Fix an error handling path in 'e1000_probe()'
  2021-06-16  5:05 [PATCH] e1000e: Fix an error handling path in 'e1000_probe()' Christophe JAILLET
  2021-06-22  8:31 ` [Intel-wired-lan] " Neftin, Sasha
@ 2021-06-24 13:37 ` Fuxbrumer, Dvora
  1 sibling, 0 replies; 3+ messages in thread
From: Fuxbrumer, Dvora @ 2021-06-24 13:37 UTC (permalink / raw)
  To: Christophe JAILLET, jesse.brandeburg, anthony.l.nguyen, davem,
	kuba, jeffrey.t.kirsher
  Cc: netdev, kernel-janitors, intel-wired-lan, linux-kernel

On 6/16/2021 08:05, Christophe JAILLET wrote:
> If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it
> must be undone by a corresponding 'pci_disable_pcie_error_reporting()'
> call, as already done in the remove function.
> 
> Fixes: 111b9dc5c981 ("e1000e: add aer support")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>   drivers/net/ethernet/intel/e1000e/netdev.c | 1 +
>   1 file changed, 1 insertion(+)
> 
Tested-by: Dvora Fuxbrumer <dvorax.fuxbrumer@linux.intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-24 13:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-16  5:05 [PATCH] e1000e: Fix an error handling path in 'e1000_probe()' Christophe JAILLET
2021-06-22  8:31 ` [Intel-wired-lan] " Neftin, Sasha
2021-06-24 13:37 ` Fuxbrumer, Dvora

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).