* [PATCH net-next] net: iosm: remove an unnecessary NULL check
@ 2021-06-19 13:51 Dan Carpenter
2021-06-20 15:50 ` Kumar, M Chetan
2021-06-21 19:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2021-06-19 13:51 UTC (permalink / raw)
To: M Chetan Kumar
Cc: Intel Corporation, David S. Miller, Jakub Kicinski, netdev,
kernel-janitors
The address of &ipc_mux->ul_adb can't be NULL because it points to the
middle of a non-NULL struct.
Fixes: 9413491e20e1 ("net: iosm: encode or decode datagram")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/wwan/iosm/iosm_ipc_mux_codec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c b/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c
index fbf3cab3394c..e634ffc6ec08 100644
--- a/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c
+++ b/drivers/net/wwan/iosm/iosm_ipc_mux_codec.c
@@ -477,7 +477,7 @@ static void ipc_mux_ul_adgh_finish(struct iosm_mux *ipc_mux)
long long bytes;
char *str;
- if (!ul_adb || !ul_adb->dest_skb) {
+ if (!ul_adb->dest_skb) {
dev_err(ipc_mux->dev, "no dest skb");
return;
}
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH net-next] net: iosm: remove an unnecessary NULL check
2021-06-19 13:51 [PATCH net-next] net: iosm: remove an unnecessary NULL check Dan Carpenter
@ 2021-06-20 15:50 ` Kumar, M Chetan
2021-06-21 19:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Kumar, M Chetan @ 2021-06-20 15:50 UTC (permalink / raw)
To: Dan Carpenter
Cc: linuxwwan, David S. Miller, Jakub Kicinski, netdev, kernel-janitors
> The address of &ipc_mux->ul_adb can't be NULL because it points to the
> middle of a non-NULL struct.
>
> Fixes: 9413491e20e1 ("net: iosm: encode or decode datagram")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/net/wwan/iosm/iosm_ipc_mux_codec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks,
Reviewed-by: M Chetan Kumar <m.chetan.kumar@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: iosm: remove an unnecessary NULL check
2021-06-19 13:51 [PATCH net-next] net: iosm: remove an unnecessary NULL check Dan Carpenter
2021-06-20 15:50 ` Kumar, M Chetan
@ 2021-06-21 19:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-06-21 19:20 UTC (permalink / raw)
To: Dan Carpenter
Cc: m.chetan.kumar, linuxwwan, davem, kuba, netdev, kernel-janitors
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Sat, 19 Jun 2021 16:51:26 +0300 you wrote:
> The address of &ipc_mux->ul_adb can't be NULL because it points to the
> middle of a non-NULL struct.
>
> Fixes: 9413491e20e1 ("net: iosm: encode or decode datagram")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/net/wwan/iosm/iosm_ipc_mux_codec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net-next] net: iosm: remove an unnecessary NULL check
https://git.kernel.org/netdev/net-next/c/d5fff4629bea
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-21 19:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-19 13:51 [PATCH net-next] net: iosm: remove an unnecessary NULL check Dan Carpenter
2021-06-20 15:50 ` Kumar, M Chetan
2021-06-21 19:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).