kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] drm/amdkfd: Fix memory leaks according to error branches
@ 2020-06-19 12:15 Markus Elfring
  0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-06-19 12:15 UTC (permalink / raw)
  To: Bernard Zhao, amd-gfx, dri-devel
  Cc: opensource.kernel, Daniel Vetter, David Airlie, Kangjie Lu,
	Felix Kühling, kernel-janitors, linux-kernel,
	Navid Emamdoost, Qiushi Wu, Aditya Pakki, Alex Deucher,
	Christian König

> The function kobject_init_and_add alloc memory like:
> kobject_init_and_add->kobject_add_varg->kobject_set_name_vargs
> ->kvasprintf_const->kstrdup_const->kstrdup->kmalloc_track_caller
> ->kmalloc_slab, in err branch this memory not free. If use
> kmemleak, this path maybe catched.
> These changes are to add kobject_put in kobject_init_and_add
> failed branch, fix potential memleak.

I suggest to improve this change description.

* Can an other wording variant be nicer?

* Will the tag “Fixes” become helpful?

Regards,
Markus

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-06-19 12:15 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-19 12:15 [PATCH] drm/amdkfd: Fix memory leaks according to error branches Markus Elfring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).