From: Scott Branden <scott.branden@broadcom.com>
To: Baokun Li <libaokun1@huawei.com>,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: weiyongjun1@huawei.com, yuehaibing@huawei.com,
yangjihong1@huawei.com, yukuai3@huawei.com,
bcm-kernel-feedback-list@broadcom.com,
kernel-janitors@vger.kernel.org, Hulk Robot <hulkci@huawei.com>,
desmond.yan@broadcom.com
Subject: Re: [PATCH -next v2] misc: bcm-vk: use list_move_tail instead of list_del/list_add_tail in bcm_vk_msg.c
Date: Wed, 9 Jun 2021 08:59:02 -0700 [thread overview]
Message-ID: <c9fa4670-51d1-0629-8514-941defeb283e@broadcom.com> (raw)
In-Reply-To: <20210609071430.1337400-1-libaokun1@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1002 bytes --]
On 2021-06-09 12:14 a.m., Baokun Li wrote:
> Using list_move_tail() instead of list_del() + list_add_tail() in bcm_vk_msg.c.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
Acked-by: Scott Branden <scott.branden@broadcom.com>
> ---
> V1->V2:
> CC mailist
>
> drivers/misc/bcm-vk/bcm_vk_msg.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/misc/bcm-vk/bcm_vk_msg.c b/drivers/misc/bcm-vk/bcm_vk_msg.c
> index 6efc52b49af6..066b9ef7fcd7 100644
> --- a/drivers/misc/bcm-vk/bcm_vk_msg.c
> +++ b/drivers/misc/bcm-vk/bcm_vk_msg.c
> @@ -354,8 +354,7 @@ static void bcm_vk_drain_all_pend(struct device *dev,
> for (num = 0; num < chan->q_nr; num++) {
> list_for_each_entry_safe(entry, tmp, &chan->pendq[num], node) {
> if ((!ctx) || (entry->ctx->idx == ctx->idx)) {
> - list_del(&entry->node);
> - list_add_tail(&entry->node, &del_q);
> + list_move_tail(&entry->node, &del_q);
> }
> }
> }
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
prev parent reply other threads:[~2021-06-09 15:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 7:14 [PATCH -next v2] misc: bcm-vk: use list_move_tail instead of list_del/list_add_tail in bcm_vk_msg.c Baokun Li
2021-06-09 15:59 ` Scott Branden [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9fa4670-51d1-0629-8514-941defeb283e@broadcom.com \
--to=scott.branden@broadcom.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=desmond.yan@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=libaokun1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
--cc=yangjihong1@huawei.com \
--cc=yuehaibing@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).