archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <>
To: Denis Efremov <>,
	Coccinelle <>,
	Gilles Muller <>,
	Julia Lawall <>,
	Masahiro Yamada <>,
	Michal Marek <>,
	Nicolas Palix <>
	"Gustavo A. R. Silva" <>,
	Kees Cook <>
Subject: Re: [PATCH v3] coccinelle: misc: add array_size_dup script to detect missed overflow checks
Date: Fri, 19 Jun 2020 15:03:18 +0000	[thread overview]
Message-ID: <> (raw)

> Changes in v2:
> - assignment operator used

I would prefer the distinction for the application of corresponding metavariables.

> Changes in v3:
>  - \(&E1\|&E2\) changed to &\(E1\|E2\)

Would it be more helpful to mention the movement of the ampersand
before SmPL disjunctions?

> +virtual context
> +virtual report
> +virtual org

Can the following SmPL code variant become more attractive?

+virtual context, report, org

> +expression subE1 <= as.E1;
> +expression subE2 <= as.E2;
> +expression as.E1, as.E2, E3;

How do you think about the following SmPL code variant?

+expression subE1 <= as.E1,
+           subE2 <= as.E2,
+           as.E1,
+           as.E2,
+           E3;

> +f"WARNING: same struct_size (line {p1[0].line})")

Please align such function parameters.[0],
+                             f"WARNING: same struct_size (line {p1[0].line})")


                 reply	other threads:[~2020-06-19 15:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).