From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Elfring <Markus.Elfring@web.de>,
Xianting Tian <xianting_tian@126.com>,
linux-scsi@vger.kernel.org,
virtualization@lists.linux-foundation.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
"James E. J. Bottomley" <jejb@linux.ibm.com>,
Jason Wang <jasowang@redhat.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH] scsi: virtio_scsi: Remove unnecessary condition checks
Date: Fri, 10 Jul 2020 07:46:54 +0000 [thread overview]
Message-ID: <d052b441-cc4d-4b2b-1442-b1a30bed2fdb@redhat.com> (raw)
In-Reply-To: <9815ef2d-d0da-d197-49d7-83559d750ff1@web.de>
On 10/07/20 09:40, Markus Elfring wrote:
>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/scsi/virtio_scsi.c?idBf82040ee66db13525dc6f14b8559890b2f4c1c#n980
>>>
>>> if (!virtscsi_cmd_cache) {
>>> pr_err("kmem_cache_create() for virtscsi_cmd_cache failed\n");
>>> - goto error;
>>> + return -ENOMEM;
>>> }
>>
>> Could be doable, but I don't see a particular benefit.
>
> Can a bit more “compliance” (with the Linux coding style) matter here?
No.
>> Having a single error loop is an advantage by itself.
>
> I do not see that a loop is involved in the implementation of the function “init”.
s/loop/label/ sorry.
Paolo
next prev parent reply other threads:[~2020-07-10 7:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 17:16 [PATCH] scsi: virtio_scsi: Remove unnecessary condition checks Markus Elfring
2020-07-09 17:25 ` Paolo Bonzini
2020-07-09 20:55 ` Markus Elfring
2020-07-10 6:32 ` Markus Elfring
2020-07-10 7:17 ` Paolo Bonzini
2020-07-10 7:40 ` Markus Elfring
2020-07-10 7:46 ` Paolo Bonzini [this message]
2020-07-10 8:11 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d052b441-cc4d-4b2b-1442-b1a30bed2fdb@redhat.com \
--to=pbonzini@redhat.com \
--cc=Markus.Elfring@web.de \
--cc=jasowang@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mst@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xianting_tian@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).