* Re: [PATCH v2 2/4] coccinelle: api: extend memdup_user rule with vmemdup_user()
@ 2020-06-08 18:32 Markus Elfring
2020-06-08 18:36 ` Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Markus Elfring @ 2020-06-08 18:32 UTC (permalink / raw)
To: Denis Efremov, Coccinelle, Gilles Muller, Julia Lawall,
Masahiro Yamada, Michal Marek, Nicolas Palix
Cc: kernel-janitors, linux-kernel
…
+++ b/scripts/coccinelle/api/memdup_user.cocci
@@ -39,6 +39,28 @@ …
…
> +@depends on patch@
> +expression from,to,size;
> +identifier l1,l2;
> +@@
> +
> +- to = \(kvmalloc\|kvzalloc\)(size,\(GFP_KERNEL\|GFP_USER\));
> ++ to = vmemdup_user(from,size);
I suggest to combine the desired adjustment with the previous SmPL rule
by using another disjunction.
> +@rv depends on !patch@
> +expression from,to,size;
> +position p;
> +statement S1,S2;
> +@@
> +
> +* to = \(kvmalloc@p\|kvzalloc@p\)(size,\(GFP_KERNEL\|GFP_USER\));
> + if (to==NULL || ...) S1
> + if (copy_from_user(to, from, size) != 0)
> + S2
How does the SmPL asterisk functionality fit to the operation
modes “org” and “report”?
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 2/4] coccinelle: api: extend memdup_user rule with vmemdup_user()
2020-06-08 18:32 [PATCH v2 2/4] coccinelle: api: extend memdup_user rule with vmemdup_user() Markus Elfring
@ 2020-06-08 18:36 ` Julia Lawall
2020-06-08 19:24 ` Markus Elfring
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2020-06-08 18:36 UTC (permalink / raw)
To: Markus Elfring
Cc: Michal Marek, Gilles Muller, kernel-janitors, Nicolas Palix,
linux-kernel, Coccinelle
[-- Attachment #1: Type: text/plain, Size: 925 bytes --]
On Mon, 8 Jun 2020, Markus Elfring wrote:
> …
> +++ b/scripts/coccinelle/api/memdup_user.cocci
> @@ -39,6 +39,28 @@ …
> …
> > +@depends on patch@
> > +expression from,to,size;
> > +identifier l1,l2;
> > +@@
> > +
> > +- to = \(kvmalloc\|kvzalloc\)(size,\(GFP_KERNEL\|GFP_USER\));
> > ++ to = vmemdup_user(from,size);
>
> I suggest to combine the desired adjustment with the previous SmPL rule
> by using another disjunction.
>
>
> > +@rv depends on !patch@
> > +expression from,to,size;
> > +position p;
> > +statement S1,S2;
> > +@@
> > +
> > +* to = \(kvmalloc@p\|kvzalloc@p\)(size,\(GFP_KERNEL\|GFP_USER\));
> > + if (to==NULL || ...) S1
> > + if (copy_from_user(to, from, size) != 0)
> > + S2
>
> How does the SmPL asterisk functionality fit to the operation
> modes “org” and “report”?
Make coccicheck uses --no-show-diff for org and report modes, so the * has
no effect in those cases.
julia
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 2/4] coccinelle: api: extend memdup_user rule with vmemdup_user()
2020-06-08 18:36 ` Julia Lawall
@ 2020-06-08 19:24 ` Markus Elfring
0 siblings, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2020-06-08 19:24 UTC (permalink / raw)
To: Julia Lawall, Denis Efremov, Coccinelle
Cc: Michal Marek, Gilles Muller, Nicolas Palix, kernel-janitors,
linux-kernel
>>> +* to = \(kvmalloc@p\|kvzalloc@p\)(size,\(GFP_KERNEL\|GFP_USER\));
>>> + if (to==NULL || ...) S1
>>> + if (copy_from_user(to, from, size) != 0)
>>> + S2
>>
>> How does the SmPL asterisk functionality fit to the operation
>> modes “org” and “report”?
>
> Make coccicheck uses --no-show-diff for org and report modes, so the * has
> no effect in those cases.
* Can it be nicer to generate only required data for each operation mode?
* Would you like to compare the usage of this command parameter with other
design approaches?
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-08 19:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-08 18:32 [PATCH v2 2/4] coccinelle: api: extend memdup_user rule with vmemdup_user() Markus Elfring
2020-06-08 18:36 ` Julia Lawall
2020-06-08 19:24 ` Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).