From: Tariq Toukan <tariqt@mellanox.com>
To: Colin King <colin.king@canonical.com>,
Boris Pismenny <borisp@mellanox.com>,
Aviad Yehezkel <aviadye@mellanox.com>,
John Fastabend <john.fastabend@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Jakub Kicinski <kuba@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Saeed Mahameed <saeedm@mellanox.com>,
netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] net/tls: fix sign extension issue when left shifting u16 value
Date: Tue, 30 Jun 2020 14:43:50 +0000 [thread overview]
Message-ID: <dfb6ef40-d5ee-fd21-afb8-1632ecb03b6d@mellanox.com> (raw)
In-Reply-To: <20200630142746.516188-1-colin.king@canonical.com>
On 6/30/2020 5:27 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Left shifting the u16 value promotes it to a int and then it
> gets sign extended to a u64. If len << 16 is greater than 0x7fffffff
> then the upper bits get set to 1 because of the implicit sign extension.
> Fix this by casting len to u64 before shifting it.
>
> Addresses-Coverity: ("integer handling issues")
> Fixes: ed9b7646b06a ("net/tls: Add asynchronous resync")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> include/net/tls.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/net/tls.h b/include/net/tls.h
> index c875c0a445a6..e5dac7e74e79 100644
> --- a/include/net/tls.h
> +++ b/include/net/tls.h
> @@ -637,7 +637,7 @@ tls_offload_rx_resync_async_request_start(struct sock *sk, __be32 seq, u16 len)
> struct tls_offload_context_rx *rx_ctx = tls_offload_ctx_rx(tls_ctx);
>
> atomic64_set(&rx_ctx->resync_async->req, ((u64)ntohl(seq) << 32) |
> - (len << 16) | RESYNC_REQ | RESYNC_REQ_ASYNC);
> + ((u64)len << 16) | RESYNC_REQ | RESYNC_REQ_ASYNC);
> rx_ctx->resync_async->loglen = 0;
> }
>
>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Thanks!
next prev parent reply other threads:[~2020-06-30 14:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 14:27 [PATCH][next] net/tls: fix sign extension issue when left shifting u16 value Colin King
2020-06-30 14:43 ` Tariq Toukan [this message]
2020-06-30 20:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfb6ef40-d5ee-fd21-afb8-1632ecb03b6d@mellanox.com \
--to=tariqt@mellanox.com \
--cc=aviadye@mellanox.com \
--cc=borisp@mellanox.com \
--cc=colin.king@canonical.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).