From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Edmundo Carmona Antoranz <eantoranz@gmail.com>
Cc: kernel-janitors@vger.kernel.org
Subject: Re: [RFC 1/2] rtc: max77686: use symbolic error messages
Date: Sun, 9 May 2021 09:39:42 +0200 [thread overview]
Message-ID: <e0358967-23ba-2509-2045-b29d83f8c1c1@wanadoo.fr> (raw)
In-Reply-To: <20210509004112.421100-1-eantoranz@gmail.com>
Le 09/05/2021 à 02:41, Edmundo Carmona Antoranz a écrit :
> Modify some error messages so that the symbolic error value be
> printed instead of a numeric value.
> ---
> drivers/rtc/rtc-max77686.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
> index ce089ed934ad..470260478752 100644
> --- a/drivers/rtc/rtc-max77686.c
> +++ b/drivers/rtc/rtc-max77686.c
> @@ -711,7 +711,8 @@ static int max77686_init_rtc_regmap(struct max77686_rtc_info *info)
> info->drv_data->regmap_config);
> if (IS_ERR(info->rtc_regmap)) {
> ret = PTR_ERR(info->rtc_regmap);
> - dev_err(info->dev, "Failed to allocate RTC regmap: %d\n", ret);
> + dev_err(info->dev, "Failed to allocate RTC regmap: %pe\n",
> + info->rtc_regmap);
> return ret;
> }
>
> @@ -763,7 +764,8 @@ static int max77686_rtc_probe(struct platform_device *pdev)
>
> if (IS_ERR(info->rtc_dev)) {
> ret = PTR_ERR(info->rtc_dev);
> - dev_err(&pdev->dev, "Failed to register RTC device: %d\n", ret);
> + dev_err(&pdev->dev, "Failed to register RTC device: %pe\n",
> + info->rtc_dev);
> goto err_rtc;
> }
>
>
Hi,
both patches LGTM.
CJ
next prev parent reply other threads:[~2021-05-09 7:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-09 0:41 [RFC 1/2] rtc: max77686: use symbolic error messages Edmundo Carmona Antoranz
2021-05-09 0:41 ` [RFC 2/2] staging: fbtft: " Edmundo Carmona Antoranz
2021-05-09 0:44 ` Edmundo Carmona Antoranz
2021-05-09 7:39 ` Christophe JAILLET [this message]
2021-05-10 4:30 ` [RFC 1/2] rtc: max77686: " Dan Carpenter
2021-05-10 5:06 ` Julia Lawall
2021-05-10 5:45 ` Marion & Christophe JAILLET
[not found] ` <alpine.DEB.2.22.394.2105092315330.24280@hadrien>
2021-05-10 4:35 ` Dan Carpenter
2021-05-10 5:03 ` Julia Lawall
2021-05-10 6:03 ` Dan Carpenter
2021-05-10 6:04 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0358967-23ba-2509-2045-b29d83f8c1c1@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=eantoranz@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).