From: Igor Russkikh <irusskikh@marvell.com>
To: Colin King <colin.king@canonical.com>,
Ariel Elior <aelior@marvell.com>,
GR-everest-linux-l2 <GR-everest-linux-l2@marvell.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Michal Kalderon <mkalderon@marvell.com>,
netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [EXT] [PATCH][V2] qed: add missing error test for DBG_STATUS_NO_MATCHING_FRAMING_MODE
Date: Thu, 25 Jun 2020 17:00:13 +0000 [thread overview]
Message-ID: <e113ec71-64ea-b819-9103-4008d20188c2@marvell.com> (raw)
In-Reply-To: <20200625164505.115425-1-colin.king@canonical.com>
On 25/06/2020 7:45 pm, Colin King wrote:
> External Email
>
> ----------------------------------------------------------------------
> From: Colin Ian King <colin.king@canonical.com>
>
> The error DBG_STATUS_NO_MATCHING_FRAMING_MODE was added to the enum
> enum dbg_status however there is a missing corresponding entry for
> this in the array s_status_str. This causes an out-of-bounds read when
> indexing into the last entry of s_status_str. Fix this by adding in
> the missing entry.
>
> Addresses-Coverity: ("Out-of-bounds read").
> Fixes: 2d22bc8354b1 ("qed: FW 8.42.2.0 debug features")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>
> V2: use the error message as suggested by Igor Russkikh
>
> ---
Thanks!
Acked-by: Igor Russkikh <irusskikh@marvell.com>
next prev parent reply other threads:[~2020-06-25 17:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 16:45 [PATCH][V2] qed: add missing error test for DBG_STATUS_NO_MATCHING_FRAMING_MODE Colin King
2020-06-25 17:00 ` Igor Russkikh [this message]
2020-06-25 19:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e113ec71-64ea-b819-9103-4008d20188c2@marvell.com \
--to=irusskikh@marvell.com \
--cc=GR-everest-linux-l2@marvell.com \
--cc=aelior@marvell.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkalderon@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).