From: Colin Ian King <colin.king@canonical.com>
To: Vinod Koul <vkoul@kernel.org>, dmaengine@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: sh: make array descs static
Date: Wed, 15 Sep 2021 12:20:58 +0100 [thread overview]
Message-ID: <e1981bb9-8965-dd85-b900-42904cf7fbf7@canonical.com> (raw)
In-Reply-To: <20210915111951.12326-1-colin.king@canonical.com>
Incorrect $SUBJECT, V2 sent
On 15/09/2021 12:19, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the read-only array ds_lut on the stack but instead it
> static. Also makes the object code smaller by 163 bytes:
>
> Before:
> text data bss dec hex filename
> 23508 4796 0 28304 6e90 ./drivers/dma/sh/rz-dmac.o
>
> After:
> text data bss dec hex filename
> 23281 4860 0 28141 6ded ./drivers/dma/sh/rz-dmac.o
>
> (gcc version 11.2.0)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/dma/sh/rz-dmac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c
> index f9f30cbeccbe..005f1a3ff634 100644
> --- a/drivers/dma/sh/rz-dmac.c
> +++ b/drivers/dma/sh/rz-dmac.c
> @@ -573,7 +573,7 @@ static void rz_dmac_issue_pending(struct dma_chan *chan)
> static u8 rz_dmac_ds_to_val_mapping(enum dma_slave_buswidth ds)
> {
> u8 i;
> - const enum dma_slave_buswidth ds_lut[] = {
> + static const enum dma_slave_buswidth ds_lut[] = {
> DMA_SLAVE_BUSWIDTH_1_BYTE,
> DMA_SLAVE_BUSWIDTH_2_BYTES,
> DMA_SLAVE_BUSWIDTH_4_BYTES,
>
prev parent reply other threads:[~2021-09-15 11:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 11:19 [PATCH] dmaengine: sh: make array descs static Colin King
2021-09-15 11:20 ` Colin Ian King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1981bb9-8965-dd85-b900-42904cf7fbf7@canonical.com \
--to=colin.king@canonical.com \
--cc=dmaengine@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).