* Re: [PATCH v3 04/14] irqchip/davinci-aintc: Fix potential resource leaks
@ 2020-06-24 13:12 Markus Elfring
2020-06-28 3:23 ` Tiezhu Yang
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2020-06-24 13:12 UTC (permalink / raw)
To: Tiezhu Yang, linux-mips
Cc: kernel-janitors, linux-kernel, Jason Cooper, Marc Zyngier,
Thomas Gleixner, Xuefeng Li
> There exists potential resource leaks in the error path, fix them.
Would you like to reconsider this change description?
https://lore.kernel.org/linux-mips/be3acb13-2963-ddf1-a867-7e30fd23a0b4@loongson.cn/
https://lkml.org/lkml/2020/6/24/498
…
> +++ b/drivers/irqchip/irq-davinci-aintc.c
…
> @@ -160,4 +160,13 @@ void __init davinci_aintc_init(const struct davinci_aintc_config *config)
> irq_base + irq_off, 32);
>
> set_handle_irq(davinci_aintc_handle_irq);
> +
> +err_domain_remove:
…
Are you sure that you would to like to release the allocated system resources
always in this function implementation?
Otherwise, I suggest to add a return statement before the source code section
for the desired exception handling.
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v3 04/14] irqchip/davinci-aintc: Fix potential resource leaks
2020-06-24 13:12 [PATCH v3 04/14] irqchip/davinci-aintc: Fix potential resource leaks Markus Elfring
@ 2020-06-28 3:23 ` Tiezhu Yang
0 siblings, 0 replies; 2+ messages in thread
From: Tiezhu Yang @ 2020-06-28 3:23 UTC (permalink / raw)
To: Markus Elfring, linux-mips
Cc: kernel-janitors, linux-kernel, Jason Cooper, Marc Zyngier,
Thomas Gleixner, Xuefeng Li
On 06/24/2020 09:12 PM, Markus Elfring wrote:
>> There exists potential resource leaks in the error path, fix them.
> Would you like to reconsider this change description?
> https://lore.kernel.org/linux-mips/be3acb13-2963-ddf1-a867-7e30fd23a0b4@loongson.cn/
> https://lkml.org/lkml/2020/6/24/498
>
>
> …
>> +++ b/drivers/irqchip/irq-davinci-aintc.c
> …
>> @@ -160,4 +160,13 @@ void __init davinci_aintc_init(const struct davinci_aintc_config *config)
>> irq_base + irq_off, 32);
>>
>> set_handle_irq(davinci_aintc_handle_irq);
>> +
>> +err_domain_remove:
> …
>
> Are you sure that you would to like to release the allocated system resources
> always in this function implementation?
>
> Otherwise, I suggest to add a return statement before the source code section
> for the desired exception handling.
Thank you! Sorry for the late reply.
I will add a return statement.
>
> Regards,
> Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-28 3:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-24 13:12 [PATCH v3 04/14] irqchip/davinci-aintc: Fix potential resource leaks Markus Elfring
2020-06-28 3:23 ` Tiezhu Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).