From: Markus Elfring <Markus.Elfring@web.de>
To: Jing Xiangfeng <jingxiangfeng@huawei.com>, linux-scsi@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Hannes Reinecke <hare@suse.de>,
"James E. J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Neerav Parikh <Neerav.Parikh@intel.com>
Subject: Re: [PATCH] scsi: fcoe: add missed kfree() in an error path
Date: Thu, 09 Jul 2020 07:22:34 +0000 [thread overview]
Message-ID: <ec1e1405-7582-0709-f2a5-a8b91e45fa1a@web.de> (raw)
In-Reply-To: <5F067CDA.8010404@huawei.com>
>>> fcoe_fdmi_info() misses to call kfree() in an error path.
>>> Add the missed function call to fix it.
>>
>> I suggest to use an additional jump target for the completion
>> of the desired exception handling.
>>
>>
>> …
>>> +++ b/drivers/scsi/fcoe/fcoe.c
>>> @@ -830,6 +830,7 @@ static void fcoe_fdmi_info(struct fc_lport *lport, struct net_device *netdev)
>>> if (rc) {
>>> printk(KERN_INFO "fcoe: Failed to retrieve FDMI "
>>> "information from netdev.\n");
>>> + kfree(fdmi);
>>> return;
>>> }
>>
>> - return;
>> + goto free_fdmi;
>>
>>
>> How do you think about to apply any further coding style adjustments?
>
> The local variable "fdmi" is invisible to the function.
I have got understanding difficulties for this information.
The function call “kfree(fdmi)” is already used at the end of this if branch.
Thus I propose to add a label there.
Do you notice any additional improvement possibilities for this software module?
Regards,
Markus
next prev parent reply other threads:[~2020-07-09 7:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 11:38 [PATCH] scsi: fcoe: add missed kfree() in an error path Markus Elfring
2020-07-09 2:11 ` Jing Xiangfeng
2020-07-09 7:22 ` Markus Elfring [this message]
2020-07-09 11:08 ` Jing Xiangfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec1e1405-7582-0709-f2a5-a8b91e45fa1a@web.de \
--to=markus.elfring@web.de \
--cc=Neerav.Parikh@intel.com \
--cc=hare@suse.de \
--cc=jejb@linux.ibm.com \
--cc=jingxiangfeng@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).