From: "Coelho, Luciano" <luciano.coelho@intel.com>
To: "dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
"christophe.jaillet@wanadoo.fr" <christophe.jaillet@wanadoo.fr>
Cc: "kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
"Berg, Johannes" <johannes.berg@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"pierre-louis.bossart@linux.intel.com"
<pierre-louis.bossart@linux.intel.com>,
"drorx.moshe@intel.com" <drorx.moshe@intel.com>,
"kuba@kernel.org" <kuba@kernel.org>
Subject: Re: [PATCH] iwlwifi: pnvm: Fix a memory leak in 'iwl_pnvm_get_from_fs()'
Date: Fri, 3 Sep 2021 08:55:27 +0000 [thread overview]
Message-ID: <ecb513984c95f69c4fb773591d873d795f344174.camel@intel.com> (raw)
In-Reply-To: <20210903081929.GB1957@kadam>
On Fri, 2021-09-03 at 11:19 +0300, Dan Carpenter wrote:
> On Thu, Sep 02, 2021 at 10:38:11PM +0200, Christophe JAILLET wrote:
> > A firmware is requested but never released in this function. This leads to
> > a memory leak in the normal execution path.
> >
> > Add the missing 'release_firmware()' call.
> > Also introduce a temp variable (new_len) in order to keep the value of
> > 'pnvm->size' after the firmware has been released.
> >
> > Fixes: cdda18fbbefa ("iwlwifi: pnvm: move file loading code to a separate function")
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Luca Coelho <luca@coelho.fi>
Kalle, can you please queue this for v5.15? I'll assign it to you.
Thanks!
--
Cheers,
Luca.
next prev parent reply other threads:[~2021-09-03 8:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 20:38 [PATCH] iwlwifi: pnvm: Fix a memory leak in 'iwl_pnvm_get_from_fs()' Christophe JAILLET
2021-09-03 8:19 ` Dan Carpenter
2021-09-03 8:55 ` Coelho, Luciano [this message]
2021-09-05 6:11 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecb513984c95f69c4fb773591d873d795f344174.camel@intel.com \
--to=luciano.coelho@intel.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=drorx.moshe@intel.com \
--cc=johannes.berg@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).